Re: [libvirt] [PATCH V5 01.5/10] tests: test recent hash addition

2011-11-18 Thread Stefan Berger
On 11/17/2011 05:07 PM, Eric Blake wrote: Excercise the new hash API, to ensure we avoid regressions. * tests/hashtest.c (testHashGetItems): New test. --- I'd still feel a bit better if we had coverage for the new function in tests/hashtest.c, but I'll let that slide to another patch; On

Re: [libvirt] [PATCH V5 01.5/10] tests: test recent hash addition

2011-11-18 Thread Eric Blake
On 11/18/2011 08:17 AM, Stefan Berger wrote: On 11/17/2011 05:07 PM, Eric Blake wrote: Excercise the new hash API, to ensure we avoid regressions. * tests/hashtest.c (testHashGetItems): New test. --- ACK Thanks; pushed. -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt

[libvirt] [PATCH V5 01.5/10] tests: test recent hash addition

2011-11-17 Thread Eric Blake
Excercise the new hash API, to ensure we avoid regressions. * tests/hashtest.c (testHashGetItems): New test. --- I'd still feel a bit better if we had coverage for the new function in tests/hashtest.c, but I'll let that slide to another patch; On second thought, writing a test now wasn't too