Re: [libvirt] [PATCH V6 3/3] Add support for file descriptor sets

2013-02-18 Thread Stefan Berger
On 02/15/2013 10:01 PM, Eric Blake wrote: On 02/14/2013 05:00 AM, Stefan Berger wrote: +static char * +qemuCommandPrintFDSet(int fdset, int fd, int open_flags, const char *name) +{ +const char *mode = ""; +virBuffer buf = VIR_BUFFER_INITIALIZER; + +if (name) { +switch ((o

Re: [libvirt] [PATCH V6 3/3] Add support for file descriptor sets

2013-02-15 Thread Eric Blake
On 02/14/2013 05:00 AM, Stefan Berger wrote: > Add support for file descriptor sets by converting some of the > command line parameters to use /dev/fdset/%d if -add-fd is found > to be supported by QEMU. For those devices libvirt now open()s > the device to obtain the file descriptor and 'transfer

Re: [libvirt] [PATCH V6 3/3] Add support for file descriptor sets

2013-02-15 Thread Stefan Berger
On 02/15/2013 03:51 PM, Corey Bryant wrote: +char *fdsetstr = NULL; +int i; + +virBufferAdd(buf, prefix, -1); +/* + * cmd == NULL hints at hotplugging; use old way of doing things I assume hotplug will be implemented at a later time by someone. Yes, this can be done inde

Re: [libvirt] [PATCH V6 3/3] Add support for file descriptor sets

2013-02-15 Thread Corey Bryant
On 02/14/2013 07:00 AM, Stefan Berger wrote: Add support for file descriptor sets by converting some of the command line parameters to use/dev/fdset/%d if -add-fd is found to be supported by QEMU. For those devices libvirt now open()s the device to obtain the file descriptor and 'transfers' the

[libvirt] [PATCH V6 3/3] Add support for file descriptor sets

2013-02-14 Thread Stefan Berger
Add support for file descriptor sets by converting some of the command line parameters to use /dev/fdset/%d if -add-fd is found to be supported by QEMU. For those devices libvirt now open()s the device to obtain the file descriptor and 'transfers' the fd using virCommand. For the following fragm