Re: [libvirt] [PATCH V9 3/3] Add support for file descriptor sets

2013-03-14 Thread Daniel P. Berrange
On Mon, Mar 11, 2013 at 03:36:56PM -0600, Eric Blake wrote: On 03/07/2013 11:14 AM, Stefan Berger wrote: Add support for file descriptor sets by converting some of the command line parameters to use /dev/fdset/%d if -add-fd is found to be supported by QEMU. For those devices libvirt now

Re: [libvirt] [PATCH V9 3/3] Add support for file descriptor sets

2013-03-14 Thread Eric Blake
On 03/12/2013 05:21 AM, Stefan Berger wrote: And here, these files support SELinux labeling, so maybe fd passing is overkill, other than proof of concept that we are doing fd passing correctly. So, I'm debating on how much of this patch needs to be applied, or whether we should split it into

Re: [libvirt] [PATCH V9 3/3] Add support for file descriptor sets

2013-03-12 Thread Stefan Berger
On 03/11/2013 05:36 PM, Eric Blake wrote: On 03/07/2013 11:14 AM, Stefan Berger wrote: serial type='dev' source path='/dev/ttyS0'/ target port='0'/ /serial serial type='pipe' source path='/tmp/testpipe'/ target port='1'/ /serial And here, these

Re: [libvirt] [PATCH V9 3/3] Add support for file descriptor sets

2013-03-11 Thread Eric Blake
On 03/07/2013 11:14 AM, Stefan Berger wrote: Add support for file descriptor sets by converting some of the command line parameters to use /dev/fdset/%d if -add-fd is found to be supported by QEMU. For those devices libvirt now open()s the device to obtain the file descriptor and 'transfers'

[libvirt] [PATCH V9 3/3] Add support for file descriptor sets

2013-03-07 Thread Stefan Berger
Add support for file descriptor sets by converting some of the command line parameters to use /dev/fdset/%d if -add-fd is found to be supported by QEMU. For those devices libvirt now open()s the device to obtain the file descriptor and 'transfers' the fd using virCommand. For the following