Re: [libvirt] [PATCH for-4.0 v3 2/2] virtio: Provide version-specific variants of virtio PCI devices

2018-11-28 Thread Caio Carrara
On Tue, Nov 27, 2018 at 11:06:17AM -0200, Eduardo Habkost wrote: > On Tue, Nov 27, 2018 at 10:56:21AM -0200, Caio Carrara wrote: > > Hello, Eduardo. > > > > Just some minor comments regarding the Python code. > > > [...] > > > +def devtype_implements(vm, devtype, implements): > > > +return de

Re: [libvirt] [PATCH for-4.0 v3 2/2] virtio: Provide version-specific variants of virtio PCI devices

2018-11-28 Thread Caio Carrara
Hello, Eduardo. Just some minor comments regarding the Python code. On Tue, Nov 27, 2018 at 12:49:59AM -0200, Eduardo Habkost wrote: > Many of the current virtio-*-pci device types actually represent > 3 different types of devices: > * virtio 1.0 non-transitional devices > * virtio 1.0 transition

Re: [libvirt] [PATCH for-4.0 v3 2/2] virtio: Provide version-specific variants of virtio PCI devices

2018-11-27 Thread Eduardo Habkost
On Tue, Nov 27, 2018 at 10:56:21AM -0200, Caio Carrara wrote: > Hello, Eduardo. > > Just some minor comments regarding the Python code. > [...] > > +def devtype_implements(vm, devtype, implements): > > +return devtype in [d['name'] for d in vm.command('qom-list-types', > > implements=impleme

Re: [libvirt] [PATCH for-4.0 v3 2/2] virtio: Provide version-specific variants of virtio PCI devices

2018-11-27 Thread Cornelia Huck
On Tue, 27 Nov 2018 00:49:59 -0200 Eduardo Habkost wrote: > Many of the current virtio-*-pci device types actually represent > 3 different types of devices: > * virtio 1.0 non-transitional devices > * virtio 1.0 transitional devices > * virtio 0.9 ("legacy device" in virtio 1.0 terminology) > >

[libvirt] [PATCH for-4.0 v3 2/2] virtio: Provide version-specific variants of virtio PCI devices

2018-11-26 Thread Eduardo Habkost
Many of the current virtio-*-pci device types actually represent 3 different types of devices: * virtio 1.0 non-transitional devices * virtio 1.0 transitional devices * virtio 0.9 ("legacy device" in virtio 1.0 terminology) That would be just an annoyance if it didn't break our device/bus compatib