Re: [libvirt] [PATCH for 5.10] Revert "qemu: Don't repeat virDomainObjEndAPI in qemuDomainBlockPull"

2019-11-27 Thread Ján Tomko
On Wed, Nov 27, 2019 at 01:52:23PM +0100, Peter Krempa wrote: This reverts commit 421c9550f5446729b513ee50f5c44e6f6969b5a2. Feel free to demote this from a sentence by removing the trailing period, to make it easier to select. qemuDomainBlockPullCommon calls virDomainObjEndAPI internally so

[libvirt] [PATCH for 5.10] Revert "qemu: Don't repeat virDomainObjEndAPI in qemuDomainBlockPull"

2019-11-27 Thread Peter Krempa
This reverts commit 421c9550f5446729b513ee50f5c44e6f6969b5a2. qemuDomainBlockPullCommon calls virDomainObjEndAPI internally so the original commit made us shed two references of @vm instead of one getting us into a premature free of @vm. This is not a straight revert as qemuDomainBlockPull was mo