Re: [libvirt] [PATCH libvirt-java 1/2] Return a byte[] array with secretGetValue

2012-07-05 Thread Daniel Veillard
On Tue, Jun 26, 2012 at 10:07:31AM +0200, Wido den Hollander wrote: We break the API with this, but Java does not support multiple method signatures with different return types. The old method returned a String, but since a secret can be binary data this type is not suited. Users who

Re: [libvirt] [PATCH libvirt-java 1/2] Return a byte[] array with secretGetValue

2012-07-05 Thread Wido den Hollander
On 05-07-12 10:20, Daniel Veillard wrote: On Tue, Jun 26, 2012 at 10:07:31AM +0200, Wido den Hollander wrote: We break the API with this, but Java does not support multiple method signatures with different return types. The old method returned a String, but since a secret can be binary data

Re: [libvirt] [PATCH libvirt-java 1/2] Return a byte[] array with secretGetValue

2012-07-05 Thread Daniel Veillard
On Thu, Jul 05, 2012 at 02:58:44PM +0200, Wido den Hollander wrote: On 05-07-12 10:20, Daniel Veillard wrote: On Tue, Jun 26, 2012 at 10:07:31AM +0200, Wido den Hollander wrote: We break the API with this, but Java does not support multiple method signatures with different return types.

[libvirt] [PATCH libvirt-java 1/2] Return a byte[] array with secretGetValue

2012-06-26 Thread Wido den Hollander
We break the API with this, but Java does not support multiple method signatures with different return types. The old method returned a String, but since a secret can be binary data this type is not suited. Users who now that their secret is in fact a String, can use cast with: Secret secret

Re: [libvirt] [PATCH libvirt-java 1/2] Return a byte[] array with secretGetValue

2012-06-26 Thread Wido den Hollander
On 06/26/2012 10:07 AM, Wido den Hollander wrote: We break the API with this, but Java does not support multiple method signatures with different return types. The old method returned a String, but since a secret can be binary data this type is not suited. Users who now that their secret is