Re: [libvirt] [PATCH libvirt 1/3] build: do not build shunloadtest if pthread missing

2012-05-08 Thread Daniel P. Berrange
On Mon, May 07, 2012 at 04:13:32PM -0600, Eric Blake wrote: ping On 05/02/2012 12:45 PM, Eric Blake wrote: On 04/20/2012 07:13 AM, Marc-André Lureau wrote: Fixes build on Windows systems we've already conditionalized -pthread; so does this (shorter) patch work to fix the problem

Re: [libvirt] [PATCH libvirt 1/3] build: do not build shunloadtest if pthread missing

2012-05-08 Thread Eric Blake
On 05/08/2012 04:16 AM, Daniel P. Berrange wrote: On Mon, May 07, 2012 at 04:13:32PM -0600, Eric Blake wrote: ping On 05/02/2012 12:45 PM, Eric Blake wrote: On 04/20/2012 07:13 AM, Marc-André Lureau wrote: Fixes build on Windows systems we've already conditionalized -pthread; so does this

Re: [libvirt] [PATCH libvirt 1/3] build: do not build shunloadtest if pthread missing

2012-05-07 Thread Eric Blake
ping On 05/02/2012 12:45 PM, Eric Blake wrote: On 04/20/2012 07:13 AM, Marc-André Lureau wrote: Fixes build on Windows systems we've already conditionalized -pthread; so does this (shorter) patch work to fix the problem instead? diff --git i/tests/Makefile.am w/tests/Makefile.am index

Re: [libvirt] [PATCH libvirt 1/3] build: do not build shunloadtest if pthread missing

2012-05-02 Thread Marc-André Lureau
ping On Fri, Apr 20, 2012 at 3:13 PM, Marc-André Lureau marcandre.lur...@gmail.com wrote: Fixes build on Windows systems ---  configure.ac      |    2 ++  tests/Makefile.am |    8 +++-  2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index

Re: [libvirt] [PATCH libvirt 1/3] build: do not build shunloadtest if pthread missing

2012-05-02 Thread Daniel P. Berrange
On Wed, May 02, 2012 at 04:57:41PM +0200, Marc-André Lureau wrote: ping On Fri, Apr 20, 2012 at 3:13 PM, Marc-André Lureau marcandre.lur...@gmail.com wrote: Fixes build on Windows systems ---  configure.ac      |    2 ++  tests/Makefile.am |    8 +++-  2 files changed, 9

Re: [libvirt] [PATCH libvirt 1/3] build: do not build shunloadtest if pthread missing

2012-05-02 Thread Eric Blake
On 05/02/2012 09:16 AM, Daniel P. Berrange wrote: On Wed, May 02, 2012 at 04:57:41PM +0200, Marc-André Lureau wrote: ping ACK, even though it is possible to have pthreads on Windows, libvirt is designed to use native windows threading instead. Pushed, and I will review the others in the

Re: [libvirt] [PATCH libvirt 1/3] build: do not build shunloadtest if pthread missing

2012-05-02 Thread Eric Blake
On 05/02/2012 12:38 PM, Eric Blake wrote: On 05/02/2012 09:16 AM, Daniel P. Berrange wrote: On Wed, May 02, 2012 at 04:57:41PM +0200, Marc-André Lureau wrote: ping ACK, even though it is possible to have pthreads on Windows, libvirt is designed to use native windows threading instead.

Re: [libvirt] [PATCH libvirt 1/3] build: do not build shunloadtest if pthread missing

2012-05-02 Thread Eric Blake
On 04/20/2012 07:13 AM, Marc-André Lureau wrote: Fixes build on Windows systems --- configure.ac |2 ++ tests/Makefile.am |8 +++- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 89fe818..347c48c 100644 --- a/configure.ac

[libvirt] [PATCH libvirt 1/3] build: do not build shunloadtest if pthread missing

2012-04-20 Thread Marc-André Lureau
Fixes build on Windows systems --- configure.ac |2 ++ tests/Makefile.am |8 +++- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 89fe818..347c48c 100644 --- a/configure.ac +++ b/configure.ac @@ -154,6 +154,8 @@