Re: [libvirt] [PATCH libvirt 1/6] conf: add MTP filesystem support to the parser

2014-08-11 Thread Daniel P. Berrange
On Thu, Aug 07, 2014 at 04:10:31PM +0200, Giuseppe Scrivano wrote: Signed-off-by: Giuseppe Scrivano gscri...@redhat.com --- src/conf/domain_conf.c | 34 +- src/conf/domain_conf.h | 1 + 2 files changed, 26 insertions(+), 9 deletions(-) diff --git

Re: [libvirt] [PATCH libvirt 1/6] conf: add MTP filesystem support to the parser

2014-08-11 Thread Giuseppe Scrivano
Daniel P. Berrange berra...@redhat.com writes: On Thu, Aug 07, 2014 at 04:10:31PM +0200, Giuseppe Scrivano wrote: Signed-off-by: Giuseppe Scrivano gscri...@redhat.com --- src/conf/domain_conf.c | 34 +- src/conf/domain_conf.h | 1 + 2 files changed, 26

Re: [libvirt] [PATCH libvirt 1/6] conf: add MTP filesystem support to the parser

2014-08-11 Thread Daniel P. Berrange
On Mon, Aug 11, 2014 at 12:15:41PM +0200, Giuseppe Scrivano wrote: Daniel P. Berrange berra...@redhat.com writes: On Thu, Aug 07, 2014 at 04:10:31PM +0200, Giuseppe Scrivano wrote: Signed-off-by: Giuseppe Scrivano gscri...@redhat.com --- src/conf/domain_conf.c | 34

Re: [libvirt] [PATCH libvirt 1/6] conf: add MTP filesystem support to the parser

2014-08-11 Thread Giuseppe Scrivano
Daniel P. Berrange berra...@redhat.com writes: Would you agree with something like this? filesystem type='mount' device name=mtp sharemtp/device ... What is the name=mtp share bit trying to reflect ? It seems we're mostly biased towards model so I think we should aim for

Re: [libvirt] [PATCH libvirt 1/6] conf: add MTP filesystem support to the parser

2014-08-11 Thread Daniel P. Berrange
On Mon, Aug 11, 2014 at 12:32:17PM +0200, Giuseppe Scrivano wrote: Daniel P. Berrange berra...@redhat.com writes: Would you agree with something like this? filesystem type='mount' device name=mtp sharemtp/device ... What is the name=mtp share bit trying to reflect ?

[libvirt] [PATCH libvirt 1/6] conf: add MTP filesystem support to the parser

2014-08-07 Thread Giuseppe Scrivano
Signed-off-by: Giuseppe Scrivano gscri...@redhat.com --- src/conf/domain_conf.c | 34 +- src/conf/domain_conf.h | 1 + 2 files changed, 26 insertions(+), 9 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index c25c74b..3bdf46a 100644 ---