[libvirt] [PATCH libvirt 2/6] include winsock2.h before windows.h

2012-01-25 Thread Marc-André Lureau
windows.h is included by threads.h. winsock2.h should be included before. Avoid the following warning: In file included from ../gnulib/lib/unistd.h:51:0, from ../src/util/util.h:30, from rpc/virkeepalive.c:29:

Re: [libvirt] [PATCH libvirt 2/6] include winsock2.h before windows.h

2012-01-25 Thread Eric Blake
On 01/25/2012 01:13 PM, Marc-André Lureau wrote: windows.h is included by threads.h. winsock2.h should be included before. Avoid the following warning: In file included from ../gnulib/lib/unistd.h:51:0, from ../src/util/util.h:30, from

Re: [libvirt] [PATCH libvirt 2/6] include winsock2.h before windows.h

2012-01-25 Thread Marc-André Lureau
- Mensaje original - On 01/25/2012 01:13 PM, Marc-André Lureau wrote: windows.h is included by threads.h. winsock2.h should be included before. Avoid the following warning: In file included from ../gnulib/lib/unistd.h:51:0, from ../src/util/util.h:30,

Re: [libvirt] [PATCH libvirt 2/6] include winsock2.h before windows.h

2012-01-25 Thread Eric Blake
On 01/25/2012 03:16 PM, Marc-André Lureau wrote: NACK. I agree that things should be fixed, but the fix should live in the problematic threads.h inclusion pattern, not in the downstream virkeepalive.c. I agree, but ff we follow that reasoning, windows.h should include winsock2.h,

Re: [libvirt] [PATCH libvirt 2/6] include winsock2.h before windows.h

2012-01-25 Thread Marc-André Lureau
Hi - Mensaje original - On 01/25/2012 03:16 PM, Marc-André Lureau wrote: Btw, I don't mind testing patches, but using mingw64 is almost a 'yum install' away :) What repo? The mingw64 compiler isn't in Fedora 16 proper. The Fedora mingw64 project repo:

Re: [libvirt] [PATCH libvirt 2/6] include winsock2.h before windows.h

2012-01-25 Thread Eric Blake
On 01/25/2012 03:42 PM, Marc-André Lureau wrote: Hi - Mensaje original - On 01/25/2012 03:16 PM, Marc-André Lureau wrote: Btw, I don't mind testing patches, but using mingw64 is almost a 'yum install' away :) What repo? The mingw64 compiler isn't in Fedora 16 proper. The