Re: [libvirt] [PATCH python v2] Fix handling of optional params in blockCopy()

2019-03-12 Thread Peter Krempa
On Mon, Mar 11, 2019 at 23:34:50 +0200, Nir Soffer wrote: > Commit 2b4bd07e0a22 (Add check for params, nparams being a dictionary) > changed the way the optional params argument is treated. If > libvirt.virDomain.blockCopy() is called without specifying params, > params is None, and the call will f

Re: [libvirt] [PATCH python v2] Fix handling of optional params in blockCopy()

2019-03-11 Thread Nir Soffer
On Mon, Mar 11, 2019 at 11:35 PM Nir Soffer wrote: > Commit 2b4bd07e0a22 (Add check for params, nparams being a dictionary) > changed the way the optional params argument is treated. If > libvirt.virDomain.blockCopy() is called without specifying params, > params is None, and the call will fail w

[libvirt] [PATCH python v2] Fix handling of optional params in blockCopy()

2019-03-11 Thread Nir Soffer
Commit 2b4bd07e0a22 (Add check for params, nparams being a dictionary) changed the way the optional params argument is treated. If libvirt.virDomain.blockCopy() is called without specifying params, params is None, and the call will fail with: TypeError: block params must be a dictionary This