[libvirt] [PATCH revision RFC 2/2] lxc: Fix return values of veth.c functions - suggested changes

2010-07-29 Thread Laine Stump
Some suggested changes to your latest patch (I did the review by applying your patch, then examining the functions that were touched, focusing just on setting of rc) Summary: 1) virAsprintf() will return the number of characters in the new string on success, not 0, so we need to only set rc

Re: [libvirt] [PATCH revision RFC 2/2] lxc: Fix return values of veth.c functions - suggested changes

2010-07-29 Thread Daniel Veillard
On Thu, Jul 29, 2010 at 12:18:24PM -0400, Laine Stump wrote: Some suggested changes to your latest patch (I did the review by applying your patch, then examining the functions that were touched, focusing just on setting of rc) Summary: 1) virAsprintf() will return the number of characters