From: "Daniel P. Berrange" <berra...@redhat.com>
The 'FILE *' handle used to read /proc/cmdline was not
closed in all codepaths. This caused coverity to identify
a resource leak.
Signed-off-by: Daniel P. Berrange <berra...@redhat.com>
---
libvirt-sandbox/libvirt-sandbox-init-qemu.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/libvirt-sandbox/libvirt-sandbox-init-qemu.c
b/libvirt-sandbox/libvirt-sandbox-init-qemu.c
index 44f5de0..998bd02 100644
--- a/libvirt-sandbox/libvirt-sandbox-init-qemu.c
+++ b/libvirt-sandbox/libvirt-sandbox-init-qemu.c
@@ -557,8 +557,9 @@ static void set_debug(void)
if (fp && fgets(line, sizeof line, fp)) {
if (strstr(line, "debug"))
debug=1;
- fclose(fp);
}
+ if (fp)
+ fclose(fp);
if (umount("/proc") < 0) {
fprintf(stderr, "libvirt-sandbox-init-qemu: %s: cannot unmount /proc:
%s\n",
__func__, strerror(errno));
--
1.8.3.1
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
