Re: [libvirt] [PATCH tck] 300-vsitype.t: skip earlier if lldptool is not available

2014-03-28 Thread Daniel P. Berrange
On Thu, Mar 27, 2014 at 04:12:16PM -0600, Mike Latimer wrote: Move the test for /usr/sbin/lldptool up so libvirt-tck will report the skip and reason, rather than passing the test as 'ok'. So we're talking about the difference between the test indicating OK 3 out of 3 tests skipped vs SKIPPED ?

Re: [libvirt] [PATCH tck] 300-vsitype.t: skip earlier if lldptool is not available

2014-03-28 Thread Daniel P. Berrange
On Fri, Mar 28, 2014 at 08:11:20AM -0600, Mike Latimer wrote: On Friday, March 28, 2014 12:28:43 PM Daniel P. Berrange wrote: On Thu, Mar 27, 2014 at 04:12:16PM -0600, Mike Latimer wrote: Move the test for /usr/sbin/lldptool up so libvirt-tck will report the skip and reason, rather

Re: [libvirt] [PATCH tck] 300-vsitype.t: skip earlier if lldptool is not available

2014-03-28 Thread Mike Latimer
On Friday, March 28, 2014 12:28:43 PM Daniel P. Berrange wrote: On Thu, Mar 27, 2014 at 04:12:16PM -0600, Mike Latimer wrote: Move the test for /usr/sbin/lldptool up so libvirt-tck will report the skip and reason, rather than passing the test as 'ok'. So we're talking about the

[libvirt] [PATCH tck] 300-vsitype.t: skip earlier if lldptool is not available

2014-03-27 Thread Mike Latimer
Move the test for /usr/sbin/lldptool up so libvirt-tck will report the skip and reason, rather than passing the test as 'ok'. --- scripts/nwfilter/300-vsitype.t | 48 ++ 1 file changed, 25 insertions(+), 23 deletions(-) diff --git