Re: [libvirt] [PATCH v1 1/3] qemu_conf.c: introduce qemuAddRemoveSharedHostdevInternal

2019-09-09 Thread Michal Privoznik
On 9/4/19 1:06 AM, Daniel Henrique Barboza wrote: qemuAddSharedHostdev() has a code similar to qemuRemoveSharedHostdev(), with exception of one line that defines the operation (add or remove). This patch introduces a new function that aggregates the common code, using a flag to switch between

Re: [libvirt] [PATCH v1 1/3] qemu_conf.c: introduce qemuAddRemoveSharedHostdevInternal

2019-09-09 Thread Pavel Hrdina
On Tue, Sep 03, 2019 at 08:06:05PM -0300, Daniel Henrique Barboza wrote: > qemuAddSharedHostdev() has a code similar to > qemuRemoveSharedHostdev(), with exception of one line that > defines the operation (add or remove). > > This patch introduces a new function that aggregates the common > code,

[libvirt] [PATCH v1 1/3] qemu_conf.c: introduce qemuAddRemoveSharedHostdevInternal

2019-09-03 Thread Daniel Henrique Barboza
qemuAddSharedHostdev() has a code similar to qemuRemoveSharedHostdev(), with exception of one line that defines the operation (add or remove). This patch introduces a new function that aggregates the common code, using a flag to switch between the operations, avoiding code repetition. No