Re: [libvirt] [PATCH v1 2/6] conf: Parse and format shmem device XML

2014-08-28 Thread Martin Kletzander
On Wed, Aug 27, 2014 at 10:52:02PM +0200, Maxime Leroy wrote: On Tue, Aug 26, 2014 at 10:42 AM, Martin Kletzander wrote: On Fri, Aug 22, 2014 at 12:47:01PM +0200, Maxime Leroy wrote: This patch adds configuration support for the shmem device as described in the schema in the previous patch.

Re: [libvirt] [PATCH v1 2/6] conf: Parse and format shmem device XML

2014-08-27 Thread Maxime Leroy
On Tue, Aug 26, 2014 at 11:02 AM, Wang Rui wrote: > On 2014/8/22 18:47, Maxime Leroy wrote: >> This patch adds configuration support for the shmem device >> as described in the schema in the previous patch. [..] >> +if (model) { >> +if ((def->model == virDomainShmemModelTypeFromString(

Re: [libvirt] [PATCH v1 2/6] conf: Parse and format shmem device XML

2014-08-27 Thread Maxime Leroy
On Tue, Aug 26, 2014 at 10:42 AM, Martin Kletzander wrote: > On Fri, Aug 22, 2014 at 12:47:01PM +0200, Maxime Leroy wrote: >> >> This patch adds configuration support for the shmem device >> as described in the schema in the previous patch. >> [...] > > This parsing using loop over children does n

Re: [libvirt] [PATCH v1 2/6] conf: Parse and format shmem device XML

2014-08-26 Thread Wang Rui
On 2014/8/22 18:47, Maxime Leroy wrote: > This patch adds configuration support for the shmem device > as described in the schema in the previous patch. > > Signed-off-by: Maxime Leroy > --- > +static virDomainShmemDefPtr > +virDomainShmemDefParseXML(xmlNodePtr node, > +

Re: [libvirt] [PATCH v1 2/6] conf: Parse and format shmem device XML

2014-08-26 Thread Martin Kletzander
On Fri, Aug 22, 2014 at 12:47:01PM +0200, Maxime Leroy wrote: This patch adds configuration support for the shmem device as described in the schema in the previous patch. Signed-off-by: Maxime Leroy --- src/conf/domain_conf.c | 249 ++- src/conf/doma

[libvirt] [PATCH v1 2/6] conf: Parse and format shmem device XML

2014-08-22 Thread Maxime Leroy
This patch adds configuration support for the shmem device as described in the schema in the previous patch. Signed-off-by: Maxime Leroy --- src/conf/domain_conf.c | 249 ++- src/conf/domain_conf.h | 41 src/libvirt_private.syms | 2 +