Re: [libvirt] [PATCH v1 4/6] qemu: Build command line for ivshmem device

2014-08-27 Thread Maxime Leroy
On Tue, Aug 26, 2014 at 10:58 AM, Martin Kletzander mklet...@redhat.com wrote: On Fri, Aug 22, 2014 at 12:47:03PM +0200, Maxime Leroy wrote: [..] It will sometimes format the command-line parameter to size=0m, which will terribly fail. We should add it to the command-line with the smallest

Re: [libvirt] [PATCH v1 4/6] qemu: Build command line for ivshmem device

2014-08-27 Thread Maxime Leroy
On Tue, Aug 26, 2014 at 11:23 AM, Wang Rui moon.wang...@huawei.com wrote: On 2014/8/22 18:47, Maxime Leroy wrote: [...] +if (!(devstr = qemuBuildIvshmemDevStr(def, dev, qemuCaps))) +return -1; +virCommandAddArg(cmd, devstr); +VIR_FREE(devstr); + +if

Re: [libvirt] [PATCH v1 4/6] qemu: Build command line for ivshmem device

2014-08-26 Thread Martin Kletzander
On Fri, Aug 22, 2014 at 12:47:03PM +0200, Maxime Leroy wrote: This patch implements support for the ivshmem device in QEMU. Example from this xml: shmem name='ivshmem0' model='ivshmem' server path='/tmp/socket-ivshmem0'/ size unit='M'32/size msi vectors='32' ioeventfd='on'/

Re: [libvirt] [PATCH v1 4/6] qemu: Build command line for ivshmem device

2014-08-26 Thread Wang Rui
On 2014/8/22 18:47, Maxime Leroy wrote: +static int +qemuBuildIvshmemCommandLine(virCommandPtr cmd, +virDomainDefPtr def, +virDomainShmemDefPtr dev, +virQEMUCapsPtr qemuCaps) +{ +char *devstr; +

[libvirt] [PATCH v1 4/6] qemu: Build command line for ivshmem device

2014-08-22 Thread Maxime Leroy
This patch implements support for the ivshmem device in QEMU. Example from this xml: shmem name='ivshmem0' model='ivshmem' server path='/tmp/socket-ivshmem0'/ size unit='M'32/size msi vectors='32' ioeventfd='on'/ /shmem The following QEMU line is built: -device