Re: [libvirt] [PATCH v1 4/6] qemu: Build command line for ivshmem device

2014-08-27 Thread Maxime Leroy
On Tue, Aug 26, 2014 at 11:23 AM, Wang Rui wrote: > On 2014/8/22 18:47, Maxime Leroy wrote: [...] >> +if (!(devstr = qemuBuildIvshmemDevStr(def, dev, qemuCaps))) >> +return -1; >> +virCommandAddArg(cmd, devstr); >> +VIR_FREE(devstr); >> + >> +if (ivshmem->server.enabled) {

Re: [libvirt] [PATCH v1 4/6] qemu: Build command line for ivshmem device

2014-08-27 Thread Maxime Leroy
On Tue, Aug 26, 2014 at 10:58 AM, Martin Kletzander wrote: > On Fri, Aug 22, 2014 at 12:47:03PM +0200, Maxime Leroy wrote: >> [..] > > It will sometimes format the command-line parameter to size=0m, which > will terribly fail. We should add it to the command-line with the > smallest scale possibl

Re: [libvirt] [PATCH v1 4/6] qemu: Build command line for ivshmem device

2014-08-26 Thread Wang Rui
On 2014/8/22 18:47, Maxime Leroy wrote: > +static int > +qemuBuildIvshmemCommandLine(virCommandPtr cmd, > +virDomainDefPtr def, > +virDomainShmemDefPtr dev, > +virQEMUCapsPtr qemuCaps) > +{ > +char *devstr; > +

Re: [libvirt] [PATCH v1 4/6] qemu: Build command line for ivshmem device

2014-08-26 Thread Martin Kletzander
On Fri, Aug 22, 2014 at 12:47:03PM +0200, Maxime Leroy wrote: This patch implements support for the ivshmem device in QEMU. Example from this xml: 32 The following QEMU line is built: -device ivshmem,size=32m,vectors=32,chardev=charshmem0,msi=on, ioeventfd=o

[libvirt] [PATCH v1 4/6] qemu: Build command line for ivshmem device

2014-08-22 Thread Maxime Leroy
This patch implements support for the ivshmem device in QEMU. Example from this xml: 32 The following QEMU line is built: -device ivshmem,size=32m,vectors=32,chardev=charshmem0,msi=on, ioeventfd=on,role=master -chardev socket,path=/tmp/socket-ivshmem0