Re: [libvirt] [PATCH v10 01/19] snapshot: Don't leak moment obj list metaroot to callers

On Wed, Jul 24, 2019 at 12:55:51AM -0500, Eric Blake wrote: > virDomainSnapshotFindByName(list, NULL) should return NULL, rather > than the internal-use-only metaroot. Most existing callers pass in a > non-NULL name; the few that don't are immediately calling > virDomainMomentSetParent (which

[libvirt] [PATCH v10 01/19] snapshot: Don't leak moment obj list metaroot to callers

virDomainSnapshotFindByName(list, NULL) should return NULL, rather than the internal-use-only metaroot. Most existing callers pass in a non-NULL name; the few that don't are immediately calling virDomainMomentSetParent (which indeed needs the metaroot if the parent name is NULL); but as the leak