Re: [libvirt] [PATCH v10 02/19] snapshot: Saner error message for duplicate create

2019-07-24 Thread Daniel P . Berrangé
On Wed, Jul 24, 2019 at 12:55:52AM -0500, Eric Blake wrote: > Any message that is easy to trigger (as evidenced by the testsuite > update) should not use 'internal error' as its category. > > Signed-off-by: Eric Blake > --- > src/conf/virdomainmomentobjlist.c | 4 ++-- > tests/virsh-snapshot

[libvirt] [PATCH v10 02/19] snapshot: Saner error message for duplicate create

2019-07-23 Thread Eric Blake
Any message that is easy to trigger (as evidenced by the testsuite update) should not use 'internal error' as its category. Signed-off-by: Eric Blake --- src/conf/virdomainmomentobjlist.c | 4 ++-- tests/virsh-snapshot | 3 +++ 2 files changed, 5 insertions(+), 2 deletions(-) diff