Re: [libvirt] [PATCH v10 08/19] backup: Parse and output checkpoint XML

2019-07-26 Thread Eric Blake
On 7/24/19 5:42 PM, Eric Blake wrote: > the amount of simplifications when you can rely on the data already > being validated was rather substantial. > >> >> If there is no downside to validation though, why only do it for one >> schema. We should do it for all of the XML parsers we have. We

Re: [libvirt] [PATCH v10 08/19] backup: Parse and output checkpoint XML

2019-07-24 Thread Eric Blake
On 7/24/19 11:40 AM, Daniel P. Berrangé wrote: > On Wed, Jul 24, 2019 at 06:17:24PM +0200, Peter Krempa wrote: >> On Wed, Jul 24, 2019 at 17:11:19 +0100, Daniel Berrange wrote: >>> On Wed, Jul 24, 2019 at 12:55:58AM -0500, Eric Blake wrote: Add a new file checkpoint_conf.c that performs the

Re: [libvirt] [PATCH v10 08/19] backup: Parse and output checkpoint XML

2019-07-24 Thread Peter Krempa
On Wed, Jul 24, 2019 at 18:10:47 +0100, Daniel Berrange wrote: > On Wed, Jul 24, 2019 at 06:55:18PM +0200, Peter Krempa wrote: > > On Wed, Jul 24, 2019 at 17:40:51 +0100, Daniel Berrange wrote: > > > On Wed, Jul 24, 2019 at 06:17:24PM +0200, Peter Krempa wrote: > > > > On Wed, Jul 24, 2019 at

Re: [libvirt] [PATCH v10 08/19] backup: Parse and output checkpoint XML

2019-07-24 Thread Daniel P . Berrangé
On Wed, Jul 24, 2019 at 06:55:18PM +0200, Peter Krempa wrote: > On Wed, Jul 24, 2019 at 17:40:51 +0100, Daniel Berrange wrote: > > On Wed, Jul 24, 2019 at 06:17:24PM +0200, Peter Krempa wrote: > > > On Wed, Jul 24, 2019 at 17:11:19 +0100, Daniel Berrange wrote: > > > > On Wed, Jul 24, 2019 at

Re: [libvirt] [PATCH v10 08/19] backup: Parse and output checkpoint XML

2019-07-24 Thread Peter Krempa
On Wed, Jul 24, 2019 at 17:40:51 +0100, Daniel Berrange wrote: > On Wed, Jul 24, 2019 at 06:17:24PM +0200, Peter Krempa wrote: > > On Wed, Jul 24, 2019 at 17:11:19 +0100, Daniel Berrange wrote: > > > On Wed, Jul 24, 2019 at 12:55:58AM -0500, Eric Blake wrote: [...] > So overall, either we should

Re: [libvirt] [PATCH v10 08/19] backup: Parse and output checkpoint XML

2019-07-24 Thread Daniel P . Berrangé
On Wed, Jul 24, 2019 at 06:17:24PM +0200, Peter Krempa wrote: > On Wed, Jul 24, 2019 at 17:11:19 +0100, Daniel Berrange wrote: > > On Wed, Jul 24, 2019 at 12:55:58AM -0500, Eric Blake wrote: > > > Add a new file checkpoint_conf.c that performs the translation to and > > > from new XML describing a

Re: [libvirt] [PATCH v10 08/19] backup: Parse and output checkpoint XML

2019-07-24 Thread Peter Krempa
On Wed, Jul 24, 2019 at 17:11:19 +0100, Daniel Berrange wrote: > On Wed, Jul 24, 2019 at 12:55:58AM -0500, Eric Blake wrote: > > Add a new file checkpoint_conf.c that performs the translation to and > > from new XML describing a checkpoint. The code shares a common base > > class with snapshots,

Re: [libvirt] [PATCH v10 08/19] backup: Parse and output checkpoint XML

2019-07-24 Thread Daniel P . Berrangé
On Wed, Jul 24, 2019 at 12:55:58AM -0500, Eric Blake wrote: > Add a new file checkpoint_conf.c that performs the translation to and > from new XML describing a checkpoint. The code shares a common base > class with snapshots, since a checkpoint similarly represents the > domain state at a moment

[libvirt] [PATCH v10 08/19] backup: Parse and output checkpoint XML

2019-07-23 Thread Eric Blake
Add a new file checkpoint_conf.c that performs the translation to and from new XML describing a checkpoint. The code shares a common base class with snapshots, since a checkpoint similarly represents the domain state at a moment in time. Add some basic testing of round trip XML handling through