Re: [libvirt] [PATCH v2] Close the source fd if the destination qemu exits during tunnelled migration

2015-10-08 Thread Shivaprasad bhat
Hi John, Sorry about the delay. Got to experiment with qemu a bit and here are my responses inline. On Wed, Sep 30, 2015 at 8:18 PM, John Ferlan wrote: > > > On 09/29/2015 10:06 AM, Shivaprasad bhat wrote: > > [...] > >>> Perhaps I should clarify my query-migrate has no

Re: [libvirt] [PATCH v2] Close the source fd if the destination qemu exits during tunnelled migration

2015-09-30 Thread John Ferlan
On 09/29/2015 10:06 AM, Shivaprasad bhat wrote: [...] >> Perhaps I should clarify my query-migrate has no timeout comment... It >> seems based on what I've read so far, the 'query-migrate' command >> started successfully, because if it hadn't we would have received a >> failure (as shown

Re: [libvirt] [PATCH v2] Close the source fd if the destination qemu exits during tunnelled migration

2015-09-28 Thread John Ferlan
On 09/28/2015 11:02 AM, Shivaprasad bhat wrote: > Hi Jon, > > Thanks a lot for attaching the patch. Replies inline. > > On Thu, Sep 24, 2015 at 1:52 AM, John Ferlan wrote: >> >> >> On 09/22/2015 07:21 AM, Shivaprasad bhat wrote: >>> On Mon, Sep 21, 2015 at 8:04 PM, John

Re: [libvirt] [PATCH v2] Close the source fd if the destination qemu exits during tunnelled migration

2015-09-28 Thread Shivaprasad bhat
Hi Jon, Thanks a lot for attaching the patch. Replies inline. On Thu, Sep 24, 2015 at 1:52 AM, John Ferlan wrote: > > > On 09/22/2015 07:21 AM, Shivaprasad bhat wrote: >> On Mon, Sep 21, 2015 at 8:04 PM, John Ferlan wrote: >>> >>> >>> On 09/21/2015

Re: [libvirt] [PATCH v2] Close the source fd if the destination qemu exits during tunnelled migration

2015-09-23 Thread John Ferlan
On 09/22/2015 07:21 AM, Shivaprasad bhat wrote: > On Mon, Sep 21, 2015 at 8:04 PM, John Ferlan wrote: >> >> >> On 09/21/2015 05:09 AM, Shivaprasad bhat wrote: >>> Thanks John for the comments. >>> >>> >>> On Fri, Sep 18, 2015 at 10:34 PM, John Ferlan

Re: [libvirt] [PATCH v2] Close the source fd if the destination qemu exits during tunnelled migration

2015-09-22 Thread Shivaprasad bhat
On Mon, Sep 21, 2015 at 8:04 PM, John Ferlan wrote: > > > On 09/21/2015 05:09 AM, Shivaprasad bhat wrote: >> Thanks John for the comments. >> >> >> On Fri, Sep 18, 2015 at 10:34 PM, John Ferlan wrote: >>> >>> >>> On 09/14/2015 10:44 AM, Shivaprasad G Bhat

Re: [libvirt] [PATCH v2] Close the source fd if the destination qemu exits during tunnelled migration

2015-09-21 Thread John Ferlan
On 09/21/2015 05:09 AM, Shivaprasad bhat wrote: > Thanks John for the comments. > > > On Fri, Sep 18, 2015 at 10:34 PM, John Ferlan wrote: >> >> >> On 09/14/2015 10:44 AM, Shivaprasad G Bhat wrote: >>> Tunnelled migration can hang if the destination qemu exits despite all

Re: [libvirt] [PATCH v2] Close the source fd if the destination qemu exits during tunnelled migration

2015-09-21 Thread Shivaprasad bhat
Thanks John for the comments. On Fri, Sep 18, 2015 at 10:34 PM, John Ferlan wrote: > > > On 09/14/2015 10:44 AM, Shivaprasad G Bhat wrote: >> Tunnelled migration can hang if the destination qemu exits despite all the >> ABI checks. This happens whenever the destination qemu

Re: [libvirt] [PATCH v2] Close the source fd if the destination qemu exits during tunnelled migration

2015-09-18 Thread John Ferlan
On 09/14/2015 10:44 AM, Shivaprasad G Bhat wrote: > Tunnelled migration can hang if the destination qemu exits despite all the > ABI checks. This happens whenever the destination qemu exits before the > complete transfer is noticed by source qemu. The savevm state checks at > runtime can fail at

[libvirt] [PATCH v2] Close the source fd if the destination qemu exits during tunnelled migration

2015-09-14 Thread Shivaprasad G Bhat
Tunnelled migration can hang if the destination qemu exits despite all the ABI checks. This happens whenever the destination qemu exits before the complete transfer is noticed by source qemu. The savevm state checks at runtime can fail at destination and cause qemu to error out. The source qemu