Re: [libvirt] [PATCH v2] Do not generate security_model when fs driver is anything but 'path'

2012-01-11 Thread Eric Blake
On 01/10/2012 06:08 AM, Daniel P. Berrange wrote: On Tue, Jan 10, 2012 at 06:23:31PM +0530, Deepak C Shetty wrote: On 01/10/2012 04:17 PM, Daniel P. Berrange wrote: On Tue, Jan 10, 2012 at 03:35:26PM +0530, Deepak C Shetty wrote: --- v2: - removed xml accessmode changes as suggested by dan.

Re: [libvirt] [PATCH v2] Do not generate security_model when fs driver is anything but 'path'

2012-01-11 Thread Deepak C Shetty
On 01/12/2012 02:18 AM, Eric Blake wrote: On 01/10/2012 06:08 AM, Daniel P. Berrange wrote: On Tue, Jan 10, 2012 at 06:23:31PM +0530, Deepak C Shetty wrote: On 01/10/2012 04:17 PM, Daniel P. Berrange wrote: On Tue, Jan 10, 2012 at 03:35:26PM +0530, Deepak C Shetty wrote: --- v2: - removed

[libvirt] [PATCH v2] Do not generate security_model when fs driver is anything but 'path'

2012-01-10 Thread Deepak C Shetty
QEMU does not support security_model for anything but 'path' fs driver type. Currently in libvirt, when security_model ( accessmode attribute) is not specified it auto-generates it irrespective of the fs driver type, which can result in a qemu error for drivers other than path. This patch ensures

Re: [libvirt] [PATCH v2] Do not generate security_model when fs driver is anything but 'path'

2012-01-10 Thread Daniel P. Berrange
On Tue, Jan 10, 2012 at 03:35:26PM +0530, Deepak C Shetty wrote: QEMU does not support security_model for anything but 'path' fs driver type. Currently in libvirt, when security_model ( accessmode attribute) is not specified it auto-generates it irrespective of the fs driver type, which can

Re: [libvirt] [PATCH v2] Do not generate security_model when fs driver is anything but 'path'

2012-01-10 Thread Deepak C Shetty
On 01/10/2012 04:17 PM, Daniel P. Berrange wrote: On Tue, Jan 10, 2012 at 03:35:26PM +0530, Deepak C Shetty wrote: --- v2: - removed xml accessmode changes as suggested by dan. - every fs driver having a default accessmode always, retained. src/qemu/qemu_command.c | 23

Re: [libvirt] [PATCH v2] Do not generate security_model when fs driver is anything but 'path'

2012-01-10 Thread Daniel P. Berrange
On Tue, Jan 10, 2012 at 06:23:31PM +0530, Deepak C Shetty wrote: On 01/10/2012 04:17 PM, Daniel P. Berrange wrote: On Tue, Jan 10, 2012 at 03:35:26PM +0530, Deepak C Shetty wrote: --- v2: - removed xml accessmode changes as suggested by dan. - every fs driver having a default accessmode