Re: [libvirt] [PATCH v2] Document preferred naming conventions

2017-03-03 Thread Laine Stump
On 03/03/2017 02:16 PM, Daniel P. Berrange wrote: On Fri, Mar 03, 2017 at 07:57:24PM +0100, Jiri Denemark wrote: Hmm, so what do we do if there is an object, an action, and a subject? Good question :-) Typically accessors which are designed to return some specific part of the object. For

Re: [libvirt] [PATCH v2] Document preferred naming conventions

2017-03-03 Thread Jiri Denemark
On Fri, Mar 03, 2017 at 19:16:58 +, Daniel P. Berrange wrote: > On Fri, Mar 03, 2017 at 07:57:24PM +0100, Jiri Denemark wrote: > > On Fri, Mar 03, 2017 at 17:47:23 +, Daniel P. Berrange wrote: > > > This documents the preferred conventions for naming files, > > > structs, enums, typedefs

Re: [libvirt] [PATCH v2] Document preferred naming conventions

2017-03-03 Thread Daniel P. Berrange
On Fri, Mar 03, 2017 at 07:57:24PM +0100, Jiri Denemark wrote: > On Fri, Mar 03, 2017 at 17:47:23 +, Daniel P. Berrange wrote: > > This documents the preferred conventions for naming files, > > structs, enums, typedefs and functions. > > > > Signed-off-by: Daniel P. Berrange

Re: [libvirt] [PATCH v2] Document preferred naming conventions

2017-03-03 Thread Jiri Denemark
On Fri, Mar 03, 2017 at 17:47:23 +, Daniel P. Berrange wrote: > This documents the preferred conventions for naming files, > structs, enums, typedefs and functions. > > Signed-off-by: Daniel P. Berrange > --- > > Changed in v2: > > - Fix typo > - Add macro docs > -

[libvirt] [PATCH v2] Document preferred naming conventions

2017-03-03 Thread Daniel P. Berrange
This documents the preferred conventions for naming files, structs, enums, typedefs and functions. Signed-off-by: Daniel P. Berrange --- Changed in v2: - Fix typo - Add macro docs - Clarify that $VERB is always last in function/macro names HACKING | 81