Re: [libvirt] [PATCH v2] Fix dnsmasq/radvd on bridges not being able to be bound to IPv6 address on "recent" kernels

2012-09-27 Thread Benjamin Cama
Le vendredi 21 septembre 2012 à 12:24 -0600, Eric Blake a écrit : > On 09/21/2012 11:04 AM, Benjamin Cama wrote: > > Ping? > > > > >>> > >>> Thanks. BTW, if this patch is commited, I'm already in AUTHORS under > >>> another email address, which is OK. > > Our syntax checker wants us to add a .ma

Re: [libvirt] [PATCH v2] Fix dnsmasq/radvd on bridges not being able to be bound to IPv6 address on "recent" kernels

2012-09-21 Thread Eric Blake
On 09/21/2012 11:04 AM, Benjamin Cama wrote: > Ping? > >>> >>> Thanks. BTW, if this patch is commited, I'm already in AUTHORS under >>> another email address, which is OK. Our syntax checker wants us to add a .mailmap listing, so that your preferred email address is in AUTHORS. Let me know if y

Re: [libvirt] [PATCH v2] Fix dnsmasq/radvd on bridges not being able to be bound to IPv6 address on "recent" kernels

2012-09-21 Thread Benjamin Cama
Ping? I just stumbled over this again today: vanillia Ubuntu 12.04, set up a network bridge with an IPv6 address, and it stays “tentative” and can't be used (it doesn't block when starting the network, though, contrary to my Debian experience). On my Debian squeeze, it's still blocking when doing

Re: [libvirt] [PATCH v2] Fix dnsmasq/radvd on bridges not being able to be bound to IPv6 address on "recent" kernels

2012-06-20 Thread Daniel P. Berrange
On Wed, Jun 20, 2012 at 01:49:30PM +0200, Benjamin Cama wrote: > Le mercredi 20 juin 2012 à 11:05 +0100, Daniel P. Berrange a écrit : > > I think you also need to have a VIR_FOFRCE_CLOSE(tapfd) in the > > very last of the cleanup jump labels. Since between the time > > we open the tapfd & close it,

Re: [libvirt] [PATCH v2] Fix dnsmasq/radvd on bridges not being able to be bound to IPv6 address on "recent" kernels

2012-06-20 Thread Benjamin Cama
Le mercredi 20 juin 2012 à 06:13 -0600, Eric Blake a écrit : > On 06/20/2012 05:49 AM, Benjamin Cama wrote: > > Thanks. BTW, if this patch is commited, I'm already in AUTHORS under > > another email address, which is OK. > > If you have two git commits under different email addresses, then we > sh

Re: [libvirt] [PATCH v2] Fix dnsmasq/radvd on bridges not being able to be bound to IPv6 address on "recent" kernels

2012-06-20 Thread Eric Blake
On 06/20/2012 05:49 AM, Benjamin Cama wrote: > Le mercredi 20 juin 2012 à 11:05 +0100, Daniel P. Berrange a écrit : >> I think you also need to have a VIR_FOFRCE_CLOSE(tapfd) in the >> very last of the cleanup jump labels. Since between the time >> we open the tapfd & close it, we might have done a

Re: [libvirt] [PATCH v2] Fix dnsmasq/radvd on bridges not being able to be bound to IPv6 address on "recent" kernels

2012-06-20 Thread Benjamin Cama
Le mercredi 20 juin 2012 à 11:05 +0100, Daniel P. Berrange a écrit : > I think you also need to have a VIR_FOFRCE_CLOSE(tapfd) in the > very last of the cleanup jump labels. Since between the time > we open the tapfd & close it, we might have done a 'goto err1' > or similar. Yes, I forgot that. Ne

Re: [libvirt] [PATCH v2] Fix dnsmasq/radvd on bridges not being able to be bound to IPv6 address on "recent" kernels

2012-06-20 Thread Daniel P. Berrange
On Tue, Jun 19, 2012 at 07:52:43PM +0200, Benjamin Cama wrote: > Hi again, > > I forgot to port my patch to the latest git master… Here is a try, not > tested, not even compiled; but it's less intrusive regarding the API > thanks to the new “flags” argument. > > --- > src/network/bridge_driver.c

[libvirt] [PATCH v2] Fix dnsmasq/radvd on bridges not being able to be bound to IPv6 address on "recent" kernels

2012-06-19 Thread Benjamin Cama
Hi again, I forgot to port my patch to the latest git master… Here is a try, not tested, not even compiled; but it's less intrusive regarding the API thanks to the new “flags” argument. --- src/network/bridge_driver.c | 19 +-- src/uml/uml_conf.c |2 +- src/util/vi