Re: [libvirt] [PATCH v2] Fix qemu-nbd cleanup crashes

2015-07-14 Thread John Ferlan
On 07/10/2015 07:51 AM, Cédric Bosdonnat wrote: The virLXCControllerAppendNBDPids function didn't properly initialize pids and npids. In case of failure it was crashing when freeing those. The nbd device pid file doesn't appear immediately after starting qemu-nbd: adding a small loop to

[libvirt] [PATCH v2] Fix qemu-nbd cleanup crashes

2015-07-10 Thread Cédric Bosdonnat
The virLXCControllerAppendNBDPids function didn't properly initialize pids and npids. In case of failure it was crashing when freeing those. The nbd device pid file doesn't appear immediately after starting qemu-nbd: adding a small loop to wait for it. Diff to v1: * Fixed a typo in a variable

Re: [libvirt] [PATCH v2] Fix qemu-nbd cleanup crashes

2015-07-10 Thread Cedric Bosdonnat
On Fri, 2015-07-10 at 13:51 +0200, Cédric Bosdonnat wrote: The virLXCControllerAppendNBDPids function didn't properly initialize pids and npids. In case of failure it was crashing when freeing those. The nbd device pid file doesn't appear immediately after starting qemu-nbd: adding a small