Re: [libvirt] [PATCH v2] Provide a helper method virDomainLiveConfigHelperMethod

2011-12-13 Thread Eric Blake
On 12/11/2011 10:16 PM, Lei Li wrote: > Changes since v1 > - With Eric's comments squashed in. I tend to put revision comments like this after the ---, so as to be helpful in the review but not part of the final commit (once it's part of the tree, we don't care how many prior reversions were om

[libvirt] [PATCH v2] Provide a helper method virDomainLiveConfigHelperMethod

2011-12-11 Thread Lei Li
Changes since v1 - With Eric's comments squashed in. This chunk of code below repeated in several functions, factor it into a helper method virDomainLiveConfigHelperMethod to eliminate duplicated code based on Eric and Adam's suggestion. I have tested it for all the relevant APIs changed. Sign