Re: [libvirt] [PATCH v2] bhyve: add e1000 nic support

2016-11-07 Thread Roman Bogorodskiy
Laine Stump wrote: > On 11/06/2016 01:09 AM, Roman Bogorodskiy wrote: > > Recently e1000 NIC support was added to bhyve; implement that in > > the bhyve driver: > > > > - Add capability check by analyzing output of the 'bhyve -s 0,e1000' > > command > > - Modify bhyveBuildNetArgStr() to

Re: [libvirt] [PATCH v2] bhyve: add e1000 nic support

2016-11-06 Thread Laine Stump
On 11/06/2016 01:09 AM, Roman Bogorodskiy wrote: Recently e1000 NIC support was added to bhyve; implement that in the bhyve driver: - Add capability check by analyzing output of the 'bhyve -s 0,e1000' command - Modify bhyveBuildNetArgStr() to support e1000 and also pass virConnectPtr

[libvirt] [PATCH v2] bhyve: add e1000 nic support

2016-11-05 Thread Roman Bogorodskiy
Recently e1000 NIC support was added to bhyve; implement that in the bhyve driver: - Add capability check by analyzing output of the 'bhyve -s 0,e1000' command - Modify bhyveBuildNetArgStr() to support e1000 and also pass virConnectPtr so it could call bhyveDriverGetCaps() to check if this

[libvirt] [PATCH v2] bhyve: add e1000 nic support

2016-11-05 Thread Roman Bogorodskiy
Changes since v1: - Fix indentation - Don't leak nic_model in bhyveBuildNetArgStr, and actually convert it to use 'goto out' to the clean up routine instead of explicit calls to VIR_FREE for every case - Add support for e1000 for argv2xml code, along with tests Roman Bogorodskiy (1): b