Re: [libvirt] [PATCH v2] host-validate: Improve CPU flags processing

2016-04-07 Thread Andrea Bolognani
On Tue, 2016-04-05 at 12:35 +0200, Ján Tomko wrote: > > +/* Split the line using " " as a delimiter. The first token > > + * will always be ":", but that's okay */ > > +if (!(tokens = virStringSplitCount(start, " ", 0, &ntokens))) > > +continue; > > + > > +  

Re: [libvirt] [PATCH v2] host-validate: Improve CPU flags processing

2016-04-05 Thread Bjoern Walk
Andrea Bolognani [2016-03-31, 05:29PM +0200]: > [...] > +if (!STRPREFIX(line, "flags") && !STRPREFIX(line, "Features")) At least on s390x, the flags line begins with a lower-cased "features". I can post a follow-up patch to include the platform specific stuff for s390x. > [...] signatu

Re: [libvirt] [PATCH v2] host-validate: Improve CPU flags processing

2016-04-05 Thread Ján Tomko
On Thu, Mar 31, 2016 at 05:26:10PM +0200, Andrea Bolognani wrote: > Instead of relying on substring search, tokenize the input > and process each CPU flag separately. This ensures CPU flag > detection will continue to work correctly even if we start > looking for CPU flags whose name might appear a

[libvirt] [PATCH v2] host-validate: Improve CPU flags processing

2016-03-31 Thread Andrea Bolognani
Instead of relying on substring search, tokenize the input and process each CPU flag separately. This ensures CPU flag detection will continue to work correctly even if we start looking for CPU flags whose name might appear as part of other CPU flags' names. The result of processing is stored in a