Re: [libvirt] [PATCH v2] hotplug: Fix libvirtd crash on qemu-attached guest

2014-10-08 Thread John Ferlan
On 10/08/2014 12:08 PM, Michal Privoznik wrote: > On 25.09.2014 17:00, John Ferlan wrote: >> https://bugzilla.redhat.com/show_bug.cgi?id=1141621 >> >> The crash in this case was because the qemu-attach code did not create >> aliases for qemu cli args. When the detach-interface code was called >>

Re: [libvirt] [PATCH v2] hotplug: Fix libvirtd crash on qemu-attached guest

2014-10-08 Thread Michal Privoznik
On 25.09.2014 17:00, John Ferlan wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1141621 The crash in this case was because the qemu-attach code did not create aliases for qemu cli args. When the detach-interface code was called it assumed aliases were set resulting in a core when dereferenci

Re: [libvirt] [PATCH v2] hotplug: Fix libvirtd crash on qemu-attached guest

2014-10-07 Thread John Ferlan
ping? Eric/Dan - since you had comments on v1... Tks, John On 09/25/2014 11:00 AM, John Ferlan wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1141621 > > The crash in this case was because the qemu-attach code did not create > aliases for qemu cli args. When the detach-interface code was

[libvirt] [PATCH v2] hotplug: Fix libvirtd crash on qemu-attached guest

2014-09-25 Thread John Ferlan
https://bugzilla.redhat.com/show_bug.cgi?id=1141621 The crash in this case was because the qemu-attach code did not create aliases for qemu cli args. When the detach-interface code was called it assumed aliases were set resulting in a core when dereferencing the still NULL alias. Adding a call to