Re: [libvirt] [PATCH v2] libxl: free ifname on libxlDomainMigrationPrepareDef

2015-12-06 Thread Jim Fehlig
On 12/06/2015 10:59 AM, Jim Fehlig wrote: > On 12/06/2015 10:04 AM, Jim Fehlig wrote: >> On 12/04/2015 12:45 PM, Joao Martins wrote: >>> Commit d2e5538b1 changes virDomainDef to include ifnames >>> that autogenerated by libxl, and that are also cleared >>> on domain cleanup. One place that's

Re: [libvirt] [PATCH v2] libxl: free ifname on libxlDomainMigrationPrepareDef

2015-12-06 Thread Jim Fehlig
On 12/04/2015 12:45 PM, Joao Martins wrote: > Commit d2e5538b1 changes virDomainDef to include ifnames > that autogenerated by libxl, and that are also cleared > on domain cleanup. One place that's missing is on > migration, when domain xml is sent to dst libvirtd and > would contain ifnames from

Re: [libvirt] [PATCH v2] libxl: free ifname on libxlDomainMigrationPrepareDef

2015-12-06 Thread Jim Fehlig
On 12/06/2015 10:04 AM, Jim Fehlig wrote: > On 12/04/2015 12:45 PM, Joao Martins wrote: >> Commit d2e5538b1 changes virDomainDef to include ifnames >> that autogenerated by libxl, and that are also cleared >> on domain cleanup. One place that's missing is on >> migration, when domain xml is sent

[libvirt] [PATCH v2] libxl: free ifname on libxlDomainMigrationPrepareDef

2015-12-04 Thread Joao Martins
Commit d2e5538b1 changes virDomainDef to include ifnames that autogenerated by libxl, and that are also cleared on domain cleanup. One place that's missing is on migration, when domain xml is sent to dst libvirtd and would contain ifnames from the source libvirtd. This would lead to erronous