Re: [libvirt] [PATCH v2] qemu: Fix crash in virDomainMemoryStats with old qemu

2014-02-06 Thread Jiri Denemark
On Wed, Feb 05, 2014 at 15:12:03 -0700, Eric Blake wrote: > On 02/05/2014 07:58 AM, John Ferlan wrote: > > > > > > On 02/05/2014 08:19 AM, Jiri Denemark wrote: > >> If virDomainMemoryStats was run on a domain with virtio balloon driver > >> running on an old qemu which supports QMP but does not s

Re: [libvirt] [PATCH v2] qemu: Fix crash in virDomainMemoryStats with old qemu

2014-02-05 Thread John Ferlan
On 02/05/2014 05:12 PM, Eric Blake wrote: > On 02/05/2014 07:58 AM, John Ferlan wrote: >> >> >> On 02/05/2014 08:19 AM, Jiri Denemark wrote: >>> If virDomainMemoryStats was run on a domain with virtio balloon driver >>> running on an old qemu which supports QMP but does not support qom-list >>> Q

Re: [libvirt] [PATCH v2] qemu: Fix crash in virDomainMemoryStats with old qemu

2014-02-05 Thread Eric Blake
On 02/05/2014 07:58 AM, John Ferlan wrote: > > > On 02/05/2014 08:19 AM, Jiri Denemark wrote: >> If virDomainMemoryStats was run on a domain with virtio balloon driver >> running on an old qemu which supports QMP but does not support qom-list >> QMP command, libvirtd would crash. The reason is we

Re: [libvirt] [PATCH v2] qemu: Fix crash in virDomainMemoryStats with old qemu

2014-02-05 Thread Franky Van Liedekerke
On 2014-02-05 14:19, Jiri Denemark wrote: If virDomainMemoryStats was run on a domain with virtio balloon driver running on an old qemu which supports QMP but does not support qom-list QMP command, libvirtd would crash. The reason is we did not check if qemuMonitorJSONGetObjectListPaths failed

Re: [libvirt] [PATCH v2] qemu: Fix crash in virDomainMemoryStats with old qemu

2014-02-05 Thread John Ferlan
On 02/05/2014 08:19 AM, Jiri Denemark wrote: > If virDomainMemoryStats was run on a domain with virtio balloon driver > running on an old qemu which supports QMP but does not support qom-list > QMP command, libvirtd would crash. The reason is we did not check if > qemuMonitorJSONGetObjectListPath

[libvirt] [PATCH v2] qemu: Fix crash in virDomainMemoryStats with old qemu

2014-02-05 Thread Jiri Denemark
If virDomainMemoryStats was run on a domain with virtio balloon driver running on an old qemu which supports QMP but does not support qom-list QMP command, libvirtd would crash. The reason is we did not check if qemuMonitorJSONGetObjectListPaths failed and moreover we even stored its result in an u