Re: [libvirt] [PATCH v2] qemu: Warning prompt if invalid dump image format specified

2011-01-27 Thread Eric Blake
On 01/26/2011 04:06 AM, Osier Yang wrote: +++ b/src/qemu/qemu_driver.c @@ -4806,16 +4806,15 @@ getCompressionType(struct qemud_driver *driver) if (driver-dumpImageFormat) { compress = qemudSaveCompressionTypeFromString(driver-dumpImageFormat); if (compress 0) { -

Re: [libvirt] [PATCH v2] qemu: Warning prompt if invalid dump image format specified

2011-01-26 Thread Osier Yang
于 2011年01月26日 01:02, Eric Blake 写道: On 01/25/2011 01:42 AM, Osier Yang wrote: getCompressionType trys to throw error when invalid dump image format is specified, or the compression program for the specified image format is not available, but at the same time, it returns enum qemud_save_formats,

[libvirt] [PATCH v2] qemu: Warning prompt if invalid dump image format specified

2011-01-25 Thread Osier Yang
getCompressionType trys to throw error when invalid dump image format is specified, or the compression program for the specified image format is not available, but at the same time, it returns enum qemud_save_formats, as a result, upper function will think it was successful, and disgard to check

Re: [libvirt] [PATCH v2] qemu: Warning prompt if invalid dump image format specified

2011-01-25 Thread Eric Blake
On 01/25/2011 01:42 AM, Osier Yang wrote: getCompressionType trys to throw error when invalid dump image format is specified, or the compression program for the specified image format is not available, but at the same time, it returns enum qemud_save_formats, as a result, upper function will