Re: [libvirt] [PATCH v2] qemu: fix msg could be a wild pointer in qemuMonitorIOProcess()

2018-06-20 Thread zhuweilun
Hi Peter, Thanks a lot for your review! I'm so sorry for the delay, please see my reply below. 在 2018/6/8 16:05, Peter Krempa 写道: > On Thu, Jun 07, 2018 at 15:09:58 +0800, Weilun Zhu wrote: >> As qemuMonitorJSONIOProcess() will unlock the qemu monitor, there is >> some extreme situation, eg qemu

Re: [libvirt] [PATCH v2] qemu: fix msg could be a wild pointer in qemuMonitorIOProcess()

2018-06-08 Thread Peter Krempa
On Thu, Jun 07, 2018 at 15:09:58 +0800, Weilun Zhu wrote: > As qemuMonitorJSONIOProcess() will unlock the qemu monitor, there is > some extreme situation, eg qemu send message to monitor twice in a short > time, where the local viriable 'msg' of qemuMonitorIOProcess() could be I'd write this as:

[libvirt] [PATCH v2] qemu: fix msg could be a wild pointer in qemuMonitorIOProcess()

2018-06-07 Thread Weilun Zhu
As qemuMonitorJSONIOProcess() will unlock the qemu monitor, there is some extreme situation, eg qemu send message to monitor twice in a short time, where the local viriable 'msg' of qemuMonitorIOProcess() could be a wild point: 1. qemuMonitorSend() assign mon->msg to parameter 'msg', which is