Re: [libvirt] [PATCH v2] qemu: report block job errors from qemu to the user

2016-11-02 Thread Nikolay Shirokovskiy
On 31.10.2016 10:10, Nikolay Shirokovskiy wrote: > > > On 28.10.2016 20:57, John Ferlan wrote: >> >> No commit message... This definitely needs one. >> >> Also when there's one patch, you don't need a cover letter - instead you >> put whatever "message" you want to give to reviewers, the

Re: [libvirt] [PATCH v2] qemu: report block job errors from qemu to the user

2016-10-31 Thread Nikolay Shirokovskiy
On 28.10.2016 20:57, John Ferlan wrote: > > No commit message... This definitely needs one. > > Also when there's one patch, you don't need a cover letter - instead you > put whatever "message" you want to give to reviewers, the pointer to the > previous version, changes with the current code,

Re: [libvirt] [PATCH v2] qemu: report block job errors from qemu to the user

2016-10-28 Thread John Ferlan
No commit message... This definitely needs one. Also when there's one patch, you don't need a cover letter - instead you put whatever "message" you want to give to reviewers, the pointer to the previous version, changes with the current code, etc. after the "---"

[libvirt] [PATCH v2] qemu: report block job errors from qemu to the user

2016-10-14 Thread Nikolay Shirokovskiy
--- src/qemu/qemu_blockjob.c | 13 +-- src/qemu/qemu_blockjob.h | 3 ++- src/qemu/qemu_domain.c | 1 + src/qemu/qemu_domain.h | 1 + src/qemu/qemu_driver.c | 4 ++-- src/qemu/qemu_migration.c| 54 +++-

[libvirt] [PATCH v2] qemu: report block job errors from qemu to the user

2016-10-14 Thread Nikolay Shirokovskiy
So that you can see nice report on migration: "error: operation failed: migration of disk sda failed: No space left on device" diff from v1: 1. drop 1 patch. Avoiding default label in switches is desired style. 2. drop 2 patch. I do not investigate enough to touch that place. 3. fix 3 patch