[libvirt] [PATCH v2] qemu: snapshot: Forbid internal snapshots with pflash firmware

2017-03-23 Thread Peter Krempa
If the variable store () file is raw qemu can't do a snapshot of it and thus the snapshot would be incomplete. QEMU does no reject such snapshot. Additionally allowing to use a qcow2 variable store backing file would solve this issue but then it would become eligible to become target of the memory

Re: [libvirt] [PATCH v2] qemu: snapshot: Forbid internal snapshots with pflash firmware

2017-03-23 Thread Laszlo Ersek
On 03/23/17 10:29, Peter Krempa wrote: > If the variable store () file is raw qemu can't do a snapshot of > it and thus the snapshot would be incomplete. QEMU does no reject such > snapshot. > > Additionally allowing to use a qcow2 variable store backing file would > solve this issue but then it w

Re: [libvirt] [PATCH v2] qemu: snapshot: Forbid internal snapshots with pflash firmware

2017-03-23 Thread Peter Krempa
On Thu, Mar 23, 2017 at 10:48:01 +0100, Laszlo Ersek wrote: > On 03/23/17 10:29, Peter Krempa wrote: > > If the variable store () file is raw qemu can't do a snapshot of > > it and thus the snapshot would be incomplete. QEMU does no reject such > > snapshot. > > > > Additionally allowing to use a

Re: [libvirt] [PATCH v2] qemu: snapshot: Forbid internal snapshots with pflash firmware

2017-03-23 Thread Laszlo Ersek
On 03/23/17 10:54, Peter Krempa wrote: > On Thu, Mar 23, 2017 at 10:48:01 +0100, Laszlo Ersek wrote: >> On 03/23/17 10:29, Peter Krempa wrote: >>> If the variable store () file is raw qemu can't do a snapshot of >>> it and thus the snapshot would be incomplete. QEMU does no reject such >>> snapshot

Re: [libvirt] [PATCH v2] qemu: snapshot: Forbid internal snapshots with pflash firmware

2017-03-23 Thread Jiri Denemark
On Thu, Mar 23, 2017 at 10:54:04 +0100, Peter Krempa wrote: > On Thu, Mar 23, 2017 at 10:48:01 +0100, Laszlo Ersek wrote: > > On 03/23/17 10:29, Peter Krempa wrote: > > > If the variable store () file is raw qemu can't do a snapshot of > > > it and thus the snapshot would be incomplete. QEMU does n

Re: [libvirt] [PATCH v2] qemu: snapshot: Forbid internal snapshots with pflash firmware

2017-03-23 Thread Peter Krempa
On Thu, Mar 23, 2017 at 11:03:02 +0100, Laszlo Ersek wrote: > On 03/23/17 10:54, Peter Krempa wrote: > > On Thu, Mar 23, 2017 at 10:48:01 +0100, Laszlo Ersek wrote: > >> On 03/23/17 10:29, Peter Krempa wrote: > >>> If the variable store () file is raw qemu can't do a snapshot of > >>> it and thus t

Re: [libvirt] [PATCH v2] qemu: snapshot: Forbid internal snapshots with pflash firmware

2017-03-23 Thread Laszlo Ersek
On 03/23/17 15:07, Peter Krempa wrote: > On Thu, Mar 23, 2017 at 11:03:02 +0100, Laszlo Ersek wrote: >> On 03/23/17 10:54, Peter Krempa wrote: >>> On Thu, Mar 23, 2017 at 10:48:01 +0100, Laszlo Ersek wrote: On 03/23/17 10:29, Peter Krempa wrote: > If the variable store () file is raw qemu

Re: [libvirt] [PATCH v2] qemu: snapshot: Forbid internal snapshots with pflash firmware

2017-03-24 Thread Peter Krempa
On Thu, Mar 23, 2017 at 17:49:56 +0100, Laszlo Ersek wrote: > On 03/23/17 15:07, Peter Krempa wrote: > > On Thu, Mar 23, 2017 at 11:03:02 +0100, Laszlo Ersek wrote: > >> On 03/23/17 10:54, Peter Krempa wrote: > >>> On Thu, Mar 23, 2017 at 10:48:01 +0100, Laszlo Ersek wrote: > On 03/23/17 10:29

Re: [libvirt] [PATCH v2] qemu: snapshot: Forbid internal snapshots with pflash firmware

2017-03-24 Thread Laszlo Ersek
On 03/24/17 13:46, Peter Krempa wrote: > On Thu, Mar 23, 2017 at 17:49:56 +0100, Laszlo Ersek wrote: >> On 03/23/17 15:07, Peter Krempa wrote: >>> On Thu, Mar 23, 2017 at 11:03:02 +0100, Laszlo Ersek wrote: On 03/23/17 10:54, Peter Krempa wrote: > On Thu, Mar 23, 2017 at 10:48:01 +0100, La

Re: [libvirt] [PATCH v2] qemu: snapshot: Forbid internal snapshots with pflash firmware

2017-03-24 Thread Peter Krempa
On Fri, Mar 24, 2017 at 14:04:08 +0100, Laszlo Ersek wrote: > On 03/24/17 13:46, Peter Krempa wrote: > > On Thu, Mar 23, 2017 at 17:49:56 +0100, Laszlo Ersek wrote: > >> On 03/23/17 15:07, Peter Krempa wrote: [...] > > > > I'll post a v3 with the option to override it, if users insist that they

Re: [libvirt] [PATCH v2] qemu: snapshot: Forbid internal snapshots with pflash firmware

2017-03-24 Thread Laszlo Ersek
On 03/24/17 14:23, Peter Krempa wrote: > On Fri, Mar 24, 2017 at 14:04:08 +0100, Laszlo Ersek wrote: >> On 03/24/17 13:46, Peter Krempa wrote: >>> On Thu, Mar 23, 2017 at 17:49:56 +0100, Laszlo Ersek wrote: On 03/23/17 15:07, Peter Krempa wrote: > > [...] > >>> >>> I'll post a v3 with the op