Re: [libvirt] [PATCH v2] qemu: sound: Support intel 'ich6' model

2011-01-21 Thread Cole Robinson
On 01/14/2011 11:20 AM, Eric Blake wrote: On 01/13/2011 02:45 PM, Cole Robinson wrote: @@ -3751,6 +3753,12 @@ qemuBuildCommandLine(virConnectPtr conn, goto error; virCommandAddArg(cmd, str); + +if (sound-model ==

Re: [libvirt] [PATCH v2] qemu: sound: Support intel 'ich6' model

2011-01-21 Thread Cole Robinson
On 01/14/2011 02:05 PM, Daniel P. Berrange wrote: On Thu, Jan 13, 2011 at 10:45:41AM -0500, Cole Robinson wrote: In QEMU, the card itself is a PCI device, but it requires a codec (either -device hda-output or -device hda-duplex) to actually output sound. We set up an hda-duplex codec by

Re: [libvirt] [PATCH v2] qemu: sound: Support intel 'ich6' model

2011-01-14 Thread Eric Blake
On 01/13/2011 02:45 PM, Cole Robinson wrote: @@ -3751,6 +3753,12 @@ qemuBuildCommandLine(virConnectPtr conn, goto error; virCommandAddArg(cmd, str); + +if (sound-model == VIR_DOMAIN_SOUND_MODEL_ICH6) { +

Re: [libvirt] [PATCH v2] qemu: sound: Support intel 'ich6' model

2011-01-14 Thread Eric Blake
On 01/13/2011 08:45 AM, Cole Robinson wrote: @@ -3751,6 +3753,12 @@ qemuBuildCommandLine(virConnectPtr conn, goto error; virCommandAddArg(cmd, str); + +if (sound-model == VIR_DOMAIN_SOUND_MODEL_ICH6) { +

Re: [libvirt] [PATCH v2] qemu: sound: Support intel 'ich6' model

2011-01-14 Thread Daniel P. Berrange
On Fri, Jan 14, 2011 at 11:13:06AM -0700, Eric Blake wrote: On 01/13/2011 08:45 AM, Cole Robinson wrote: @@ -3751,6 +3753,12 @@ qemuBuildCommandLine(virConnectPtr conn, goto error; virCommandAddArg(cmd, str); + +if

Re: [libvirt] [PATCH v2] qemu: sound: Support intel 'ich6' model

2011-01-14 Thread Daniel P. Berrange
On Thu, Jan 13, 2011 at 10:45:41AM -0500, Cole Robinson wrote: In QEMU, the card itself is a PCI device, but it requires a codec (either -device hda-output or -device hda-duplex) to actually output sound. We set up an hda-duplex codec by default: I think it's important that a simple sound

[libvirt] [PATCH v2] qemu: sound: Support intel 'ich6' model

2011-01-13 Thread Cole Robinson
In QEMU, the card itself is a PCI device, but it requires a codec (either -device hda-output or -device hda-duplex) to actually output sound. We set up an hda-duplex codec by default: I think it's important that a simple sound model='ich6'/ sets up a useful codec, to have consistent behavior with

Re: [libvirt] [PATCH v2] qemu: sound: Support intel 'ich6' model

2011-01-13 Thread Cole Robinson
On 01/13/2011 03:21 PM, Eric Blake wrote: On 01/13/2011 08:45 AM, Cole Robinson wrote: In QEMU, the card itself is a PCI device, but it requires a codec (either -device hda-output or -device hda-duplex) to actually output sound. We set up an hda-duplex codec by default: I think it's important