Re: [libvirt] [PATCH v2] qemu_migration: Avoid crashing if domain dies too quickly

2013-10-18 Thread Michal Privoznik
[libvirt] [PATCH v2] qemu_migration: Avoid crashing if domain >> dies too quickly >> >> On 18.10.2013 08:22, Wangyufei (A) wrote: >>> I'm sorry. I didn't get what you mean. >>> >>> In virQEMUCapsInitQMP >>> >>> if (!(xmlopt

Re: [libvirt] [PATCH v2] qemu_migration: Avoid crashing if domain dies too quickly

2013-10-18 Thread Wangyufei (A)
> -Original Message- > From: Michal Privoznik [mailto:mpriv...@redhat.com] > Sent: Friday, October 18, 2013 2:37 PM > To: Wangyufei (A) > Cc: libvir-list@redhat.com; Wangrui (K) > Subject: Re: [libvirt] [PATCH v2] qemu_migration: Avoid crashing if domain > die

Re: [libvirt] [PATCH v2] qemu_migration: Avoid crashing if domain dies too quickly

2013-10-17 Thread Michal Privoznik
On 18.10.2013 08:22, Wangyufei (A) wrote: > I'm sorry. I didn't get what you mean. > > In virQEMUCapsInitQMP > > if (!(xmlopt = virDomainXMLOptionNew(NULL, NULL, NULL)) || > !(vm = virDomainObjNew(xmlopt))) > goto cleanup; > > vm->pid = pid; //Apparently vm is not NULL

Re: [libvirt] [PATCH v2] qemu_migration: Avoid crashing if domain dies too quickly

2013-10-17 Thread Wangyufei (A)
-- > >> From: libvir-list-boun...@redhat.com > >> [mailto:libvir-list-boun...@redhat.com] On Behalf Of Michal Privoznik > >> Sent: Friday, October 11, 2013 8:15 PM > >> To: libvir-list@redhat.com > >> Subject: [libvirt] [PATCH v2] qemu_migration: Avoid c

Re: [libvirt] [PATCH v2] qemu_migration: Avoid crashing if domain dies too quickly

2013-10-17 Thread Michal Privoznik
at.com] On Behalf Of Michal Privoznik >> Sent: Friday, October 11, 2013 8:15 PM >> To: libvir-list@redhat.com >> Subject: [libvirt] [PATCH v2] qemu_migration: Avoid crashing if domain dies >> too quickly >> @@ -2673,6 +2677,8 @@ cleanup: >> virComma

Re: [libvirt] [PATCH v2] qemu_migration: Avoid crashing if domain dies too quickly

2013-10-17 Thread Wangyufei (A)
8:15 PM > To: libvir-list@redhat.com > Subject: [libvirt] [PATCH v2] qemu_migration: Avoid crashing if domain dies > too quickly > > I've noticed a SIGSEGV-ing libvirtd on the destination when the qemu > died too quickly = in Prepare phase. What is happening here

Re: [libvirt] [PATCH v2] qemu_migration: Avoid crashing if domain dies too quickly

2013-10-11 Thread Eric Blake
On 10/11/2013 06:14 AM, Michal Privoznik wrote: > I've noticed a SIGSEGV-ing libvirtd on the destination when the qemu > died too quickly = in Prepare phase. What is happening here is: > > > 4) [Thread 3262] So the even loop starts triggering EOF: s/even/event/ > > The mon->vm is set in qemuM

[libvirt] [PATCH v2] qemu_migration: Avoid crashing if domain dies too quickly

2013-10-11 Thread Michal Privoznik
I've noticed a SIGSEGV-ing libvirtd on the destination when the qemu died too quickly = in Prepare phase. What is happening here is: 1) [Thread 3493] We are in qemuMigrationPrepareAny() and calling qemuProcessStart() which subsequently calls qemuProcessWaitForMonitor() and qemuConnectMonitor(). So