On 8/9/19 9:02 AM, Jiri Denemark wrote:
> On Wed, Jul 31, 2019 at 14:52:17 -0500, Eric Blake wrote:
>> On 7/31/19 2:45 PM, Daniel Henrique Barboza wrote:
>>> Max,
>>>
>>> Code looks ok. Two tests (virsh-checkpoint and virsh-snapshot) are
>>> failing, but they are also failing on master, thus I say
On Wed, Jul 31, 2019 at 14:52:17 -0500, Eric Blake wrote:
> On 7/31/19 2:45 PM, Daniel Henrique Barboza wrote:
> > Max,
> >
> > Code looks ok. Two tests (virsh-checkpoint and virsh-snapshot) are
> > failing, but they are also failing on master, thus I say this patch get a
> > pass because it
On Tue, Jul 23, 2019 at 16:47:05 -0300, Maxiwell S. Garcia wrote:
> The snapshot-create operation of running guests saves the live
> XML and uses it to replace the active and inactive domain in
> case of revert. So, the config XML is ignored by the snapshot
> process. This commit changes it and
On Wed, Jul 31, 2019 at 02:52:17PM -0500, Eric Blake wrote:
> On 7/31/19 2:45 PM, Daniel Henrique Barboza wrote:
> > Max,
> >
> > Code looks ok. Two tests (virsh-checkpoint and virsh-snapshot) are
> > failing, but they are also failing on master, thus I say this patch get a
> > pass because it
Eric,
On 7/31/19 4:52 PM, Eric Blake wrote:
On 7/31/19 2:45 PM, Daniel Henrique Barboza wrote:
Max,
Code looks ok. Two tests (virsh-checkpoint and virsh-snapshot) are
failing, but they are also failing on master, thus I say this patch get a
pass because it didn't break anything else.
What
On 7/31/19 2:45 PM, Daniel Henrique Barboza wrote:
> Max,
>
> Code looks ok. Two tests (virsh-checkpoint and virsh-snapshot) are
> failing, but they are also failing on master, thus I say this patch get a
> pass because it didn't break anything else.
What failures are you seeing? Those were just
Max,
Code looks ok. Two tests (virsh-checkpoint and virsh-snapshot) are
failing, but they are also failing on master, thus I say this patch get a
pass because it didn't break anything else.
Reviewed-by: Daniel Henrique Barboza
On 7/23/19 4:47 PM, Maxiwell S. Garcia wrote:
The
The snapshot-create operation of running guests saves the live
XML and uses it to replace the active and inactive domain in
case of revert. So, the config XML is ignored by the snapshot
process. This commit changes it and adds the config XML in the
snapshot XML as the entry.
In case of offline