On 07/14/2011 06:23 AM, Jiri Denemark wrote:
>> +void ATTRIBUTE_NONNULL(1)
>> +virStorageFileFreeMetadata(virStorageFileMetadata *meta)
>> +{
>> +VIR_FREE(meta->backingStore);
>> +VIR_FREE(meta);
>> +}
>
> We like having free-like functions to work with NULL arguments, shouldn't we
> follo
On Thu, Jul 14, 2011 at 12:56:26 +0200, Michal Privoznik wrote:
> Getting metadata on storage allocates a memory (path) which need to
> be freed after use otherwise it gets leaked. This means after use of
> virStorageFileGetMetadataFromFD or virStorageFileGetMetadata one
> must call virStorageFileF
Getting metadata on storage allocates a memory (path) which need to
be freed after use otherwise it gets leaked. This means after use of
virStorageFileGetMetadataFromFD or virStorageFileGetMetadata one
must call virStorageFileFreeMetadata to free it. This function frees
structure internals and stru
