Re: [libvirt] [PATCH v2] storage: only run safezero if allocation is > 0

2015-08-24 Thread Guido Günther
Hi, On Mon, Aug 24, 2015 at 01:27:42PM +0200, Martin Kletzander wrote: > On Mon, Aug 24, 2015 at 12:55:22PM +0200, Guido Günther wrote: > >While a zero allocation in safezero should be fine it isn't when we use > >posix_fallocate which returns EINVAL on a zero allocation. > > > >While we could skip

Re: [libvirt] [PATCH v2] storage: only run safezero if allocation is > 0

2015-08-24 Thread Martin Kletzander
On Mon, Aug 24, 2015 at 12:55:22PM +0200, Guido Günther wrote: While a zero allocation in safezero should be fine it isn't when we use posix_fallocate which returns EINVAL on a zero allocation. While we could skip the zero allocation in safezero_posix_fallocate it's an optimization to do it for

[libvirt] [PATCH v2] storage: only run safezero if allocation is > 0

2015-08-24 Thread Guido Günther
While a zero allocation in safezero should be fine it isn't when we use posix_fallocate which returns EINVAL on a zero allocation. While we could skip the zero allocation in safezero_posix_fallocate it's an optimization to do it for all allocations. This fixes vm installation via virtinst for me