Re: [libvirt] [PATCH v2] systemd: fix build without dbus

2015-01-21 Thread Pavel Hrdina
On 01/19/2015 02:36 PM, Daniel P. Berrange wrote: The virDBusMethodCall method has a DBusError as one of its parameters. If the caller wants to pass a non-NULL value for this, it immediately makes the calling code require DBus at build time. This has led to breakage of non-DBus builds several

Re: [libvirt] [PATCH v2] systemd: fix build without dbus

2015-01-21 Thread Daniel P. Berrange
On Wed, Jan 21, 2015 at 03:15:31PM +0100, Ján Tomko wrote: On 01/19/2015 02:36 PM, Daniel P. Berrange wrote: The virDBusMethodCall method has a DBusError as one of its parameters. If the caller wants to pass a non-NULL value for this, it immediately makes the calling code require DBus at

Re: [libvirt] [PATCH v2] systemd: fix build without dbus

2015-01-21 Thread Ján Tomko
On 01/19/2015 02:36 PM, Daniel P. Berrange wrote: The virDBusMethodCall method has a DBusError as one of its parameters. If the caller wants to pass a non-NULL value for this, it immediately makes the calling code require DBus at build time. This has led to breakage of non-DBus builds several

[libvirt] [PATCH v2] systemd: fix build without dbus

2015-01-19 Thread Daniel P. Berrange
The virDBusMethodCall method has a DBusError as one of its parameters. If the caller wants to pass a non-NULL value for this, it immediately makes the calling code require DBus at build time. This has led to breakage of non-DBus builds several times. It is desirable that only the virdbus.c file