Re: [libvirt] [PATCH v2] util: avoid fds leak when virEventPollAddHandle fail

2011-07-19 Thread Eric Blake
On 07/19/2011 03:54 AM, Daniel P. Berrange wrote: On Tue, Jul 19, 2011 at 05:34:28PM +0800, a...@redhat.com wrote: * src/util/event_poll.c: only fix file descriptors leak on when virEventPollAddHandle fail on virEventPollInit function. @@ -657,6 +658,8 @@ int virEventPollInit(void)

Re: [libvirt] [PATCH v2] util: avoid fds leak when virEventPollAddHandle fail

2011-07-19 Thread Daniel P. Berrange
On Tue, Jul 19, 2011 at 05:34:28PM +0800, a...@redhat.com wrote: > * src/util/event_poll.c: only fix file descriptors leak on when > virEventPollAddHandle fail on virEventPollInit function. > > Detected in valgrind run: > ==1254== > ==1254== FILE DESCRIPTORS: 6 open at exit. > ==1254== Open fil

[libvirt] [PATCH v2] util: avoid fds leak when virEventPollAddHandle fail

2011-07-19 Thread ajia
* src/util/event_poll.c: only fix file descriptors leak on when virEventPollAddHandle fail on virEventPollInit function. Detected in valgrind run: ==1254== ==1254== FILE DESCRIPTORS: 6 open at exit. ==1254== Open file descriptor 5: ==1254==at 0x30736D9D47: pipe2 (syscall-template.S:82) ==12