Re: [libvirt] [PATCH v2] virsh: avoid missing zero value judgement in cmdBlkiotune

2011-07-28 Thread Michal Privoznik
On 28.07.2011 11:04, Alex Jia wrote: * tools/virsh.c: avoid missing zero value judgement in cmdBlkiotune, when weight is equal to 0, the cmdBlkiotune will not raise any error information when judge weight value first time, and execute else branch to judge weight value again, strncpy(temp

Re: [libvirt] [PATCH v2] virsh: avoid missing zero value judgement in cmdBlkiotune

2011-07-28 Thread Alex Jia
On 07/28/2011 05:55 PM, Michal Privoznik wrote: On 28.07.2011 11:26, Alex Jia wrote: On 07/28/2011 05:04 PM, Alex Jia wrote: * tools/virsh.c: avoid missing zero value judgement in cmdBlkiotune, when weight is equal to 0, the cmdBlkiotune will not raise any error information when judge weight v

Re: [libvirt] [PATCH v2] virsh: avoid missing zero value judgement in cmdBlkiotune

2011-07-28 Thread Michal Privoznik
On 28.07.2011 11:26, Alex Jia wrote: On 07/28/2011 05:04 PM, Alex Jia wrote: * tools/virsh.c: avoid missing zero value judgement in cmdBlkiotune, when weight is equal to 0, the cmdBlkiotune will not raise any error information when judge weight value first time, and execute else branch to judge

Re: [libvirt] [PATCH v2] virsh: avoid missing zero value judgement in cmdBlkiotune

2011-07-28 Thread Alex Jia
On 07/28/2011 05:16 PM, Michal Privoznik wrote: On 28.07.2011 11:04, Alex Jia wrote: * tools/virsh.c: avoid missing zero value judgement in cmdBlkiotune, when weight is equal to 0, the cmdBlkiotune will not raise any error information when judge weight value first time, and execute else b

Re: [libvirt] [PATCH v2] virsh: avoid missing zero value judgement in cmdBlkiotune

2011-07-28 Thread Alex Jia
On 07/28/2011 05:04 PM, Alex Jia wrote: * tools/virsh.c: avoid missing zero value judgement in cmdBlkiotune, when weight is equal to 0, the cmdBlkiotune will not raise any error information when judge weight value first time, and execute else branch to judge weight value again, strncpy(t

[libvirt] [PATCH v2] virsh: avoid missing zero value judgement in cmdBlkiotune

2011-07-28 Thread ajia
* tools/virsh.c: avoid missing zero value judgement in cmdBlkiotune, when weight is equal to 0, the cmdBlkiotune will not raise any error information when judge weight value first time, and execute else branch to judge weight value again, strncpy(temp->field, VIR_DOMAIN_BLKIO_WEIGHT, sizeof(