Re: [libvirt] [PATCH v2] virsh: fix build without readline

2018-01-15 Thread Roman Bogorodskiy
Erik Skultety wrote: > On Sat, Jan 13, 2018 at 06:46:00PM +0400, Roman Bogorodskiy wrote: > > Completion in virsh is enabled when readline is available. In order to > > fix build when it's not available, do the following: > > > > * Unconditionally add virsh-completer.[ch] and > >

Re: [libvirt] [PATCH v2] virsh: fix build without readline

2018-01-15 Thread Erik Skultety
On Sat, Jan 13, 2018 at 06:46:00PM +0400, Roman Bogorodskiy wrote: > Completion in virsh is enabled when readline is available. In order to > fix build when it's not available, do the following: > > * Unconditionally add virsh-completer.[ch] and >virt-admin-completer.[ch] to the build, and

[libvirt] [PATCH v2] virsh: fix build without readline

2018-01-13 Thread Roman Bogorodskiy
Completion in virsh is enabled when readline is available. In order to fix build when it's not available, do the following: * Unconditionally add virsh-completer.[ch] and virt-admin-completer.[ch] to the build, and provide stub functions for when readline is not available. This way virsh