Re: [libvirt] [PATCH v2 0/2] add debugcon-isa chardev guest interface

2019-02-14 Thread Andrea Bolognani
On Thu, 2019-02-14 at 12:33 +0100, Ján Tomko wrote: > Given that your only compelling argument is "it's extra work" I went > ahead and done the work: > https://www.redhat.com/archives/libvir-list/2019-February/msg00860.html I won't NACK that series, even though I disagree with the approach taken.

Re: [libvirt] [PATCH v2 0/2] add debugcon-isa chardev guest interface

2019-02-14 Thread Ján Tomko
On Wed, Feb 13, 2019 at 05:18:55PM +0100, Andrea Bolognani wrote: On Wed, 2019-02-13 at 13:29 +0100, Ján Tomko wrote: On Wed, Feb 13, 2019 at 10:59:28AM +0100, Andrea Bolognani wrote: > On Wed, 2019-02-13 at 10:03 +0100, Ján Tomko wrote: > > Also, the device will be given an iobase by QEMU, we

Re: [libvirt] [PATCH v2 0/2] add debugcon-isa chardev guest interface

2019-02-13 Thread Andrea Bolognani
On Wed, 2019-02-13 at 13:29 +0100, Ján Tomko wrote: > On Wed, Feb 13, 2019 at 10:59:28AM +0100, Andrea Bolognani wrote: > > On Wed, 2019-02-13 at 10:03 +0100, Ján Tomko wrote: > > > Also, the device will be given an iobase by QEMU, we should represent > > > that in the XML and fill in that

Re: [libvirt] [PATCH v2 0/2] add debugcon-isa chardev guest interface

2019-02-13 Thread Ján Tomko
On Wed, Feb 13, 2019 at 10:59:28AM +0100, Andrea Bolognani wrote: On Wed, 2019-02-13 at 10:03 +0100, Ján Tomko wrote: On Tue, Feb 12, 2019 at 05:21:56PM +0100, Andrea Bolognani wrote: > On Tue, 2019-02-12 at 16:07 +0100, Ján Tomko wrote: > > > > There should be no pressure to maintain the 1:1

Re: [libvirt] [PATCH v2 0/2] add debugcon-isa chardev guest interface

2019-02-13 Thread Andrea Bolognani
On Wed, 2019-02-13 at 10:03 +0100, Ján Tomko wrote: > On Tue, Feb 12, 2019 at 05:21:56PM +0100, Andrea Bolognani wrote: > > On Tue, 2019-02-12 at 16:07 +0100, Ján Tomko wrote: > > > > > There should be no pressure to maintain the 1:1 mapping. > > > > > For QEMU, the devices need to be represented

Re: [libvirt] [PATCH v2 0/2] add debugcon-isa chardev guest interface

2019-02-13 Thread Ján Tomko
On Tue, Feb 12, 2019 at 05:21:56PM +0100, Andrea Bolognani wrote: On Tue, 2019-02-12 at 16:07 +0100, Ján Tomko wrote: On Tue, Feb 12, 2019 at 02:44:05PM +, Nikolay Shirokovskiy wrote: > On 12.02.2019 17:37, Ján Tomko wrote: > > On Thu, Feb 07, 2019 at 02:31:47PM +0300, Nikolay Shirokovskiy

Re: [libvirt] [PATCH v2 0/2] add debugcon-isa chardev guest interface

2019-02-12 Thread Andrea Bolognani
On Tue, 2019-02-12 at 16:07 +0100, Ján Tomko wrote: > On Tue, Feb 12, 2019 at 02:44:05PM +, Nikolay Shirokovskiy wrote: > > On 12.02.2019 17:37, Ján Tomko wrote: > > > On Thu, Feb 07, 2019 at 02:31:47PM +0300, Nikolay Shirokovskiy wrote: > > > > Diff from v1 [1]: > > > > = > >

Re: [libvirt] [PATCH v2 0/2] add debugcon-isa chardev guest interface

2019-02-12 Thread Ján Tomko
On Tue, Feb 12, 2019 at 02:44:05PM +, Nikolay Shirokovskiy wrote: On 12.02.2019 17:37, Ján Tomko wrote: On Thu, Feb 07, 2019 at 02:31:47PM +0300, Nikolay Shirokovskiy wrote: Diff from v1 [1]: = - expose the device as serial device instead of channel in config I use

Re: [libvirt] [PATCH v2 0/2] add debugcon-isa chardev guest interface

2019-02-12 Thread Nikolay Shirokovskiy
On 12.02.2019 17:37, Ján Tomko wrote: > On Thu, Feb 07, 2019 at 02:31:47PM +0300, Nikolay Shirokovskiy wrote: >> Diff from v1 [1]: >> = >> - expose the device as serial device instead of channel in config >> >> I use isa-debugcon name becase libvirt passes these names to qemu

Re: [libvirt] [PATCH v2 0/2] add debugcon-isa chardev guest interface

2019-02-12 Thread Ján Tomko
On Thu, Feb 07, 2019 at 02:31:47PM +0300, Nikolay Shirokovskiy wrote: Diff from v1 [1]: = - expose the device as serial device instead of channel in config I use isa-debugcon name becase libvirt passes these names to qemu as-is so I don't want to make exception for this device.

[libvirt] [PATCH v2 0/2] add debugcon-isa chardev guest interface

2019-02-07 Thread Nikolay Shirokovskiy
Diff from v1 [1]: = - expose the device as serial device instead of channel in config I use isa-debugcon name becase libvirt passes these names to qemu as-is so I don't want to make exception for this device. First version discussion: [1]