Re: [libvirt] [PATCH v2 0/2] small gluster fixes

2014-02-07 Thread Christophe Fergeau
On Thu, Feb 06, 2014 at 01:56:17PM -0700, Eric Blake wrote: On 02/06/2014 11:09 AM, Christophe Fergeau wrote: +/* Check if VIR_CONNECT_LIST_STORAGE_POOLS_FILTERS_POOL_TYPE seems to + * contain all virConnectListAllStoragePoolsFlags elements + */

[libvirt] [PATCH v2 0/2] small gluster fixes

2014-02-06 Thread Christophe Fergeau
Hi, I noticed that virsh pool-list --type gluster is not giving me an empty list as expected, but rather the list of active pools. This is happening because virConnectListAllStoragePools() is returning VIR_ERROR_INVALID_ARG because VIR_CONNECT_LIST_STORAGE_POOLS_GLUSTER is unrecognized.

Re: [libvirt] [PATCH v2 0/2] small gluster fixes

2014-02-06 Thread Eric Blake
On 02/06/2014 11:09 AM, Christophe Fergeau wrote: I've played a bit with adding some compile time checks to avoid this in the future, but while they work, they are a bit ugly-looking, and they would require some changes in docs/apibuild.py to teach it to parse 1 N, or to make it ignore