On 10/03/2016 10:49 AM, Peter Krempa wrote:
> On Mon, Oct 03, 2016 at 10:46:07 -0400, John Ferlan wrote:
>> [...]
>>
Since you didn't explicitly state which checks, I'm assuming you mean
either:
if (!(devices = virJSONValueObjectGetArray(reply, "return"))) {
v
On Mon, Oct 03, 2016 at 10:46:07 -0400, John Ferlan wrote:
> [...]
>
> >> Since you didn't explicitly state which checks, I'm assuming you mean
> >> either:
> >>
> >> if (!(devices = virJSONValueObjectGetArray(reply, "return"))) {
> >> virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
> >>
[...]
>> Since you didn't explicitly state which checks, I'm assuming you mean
>> either:
>>
>> if (!(devices = virJSONValueObjectGetArray(reply, "return"))) {
>> virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
>>_("block info reply was missing device list"));
>>
On Mon, Oct 03, 2016 at 07:49:44 -0400, John Ferlan wrote:
> On 10/03/2016 03:22 AM, Peter Krempa wrote:
> > On Fri, Sep 30, 2016 at 14:39:16 -0400, John Ferlan wrote:
> >> v1: http://www.redhat.com/archives/libvir-list/2016-September/msg01446.html
> >>
> >> NOTE: Patch 1 already ACK'd
> >>
> >> Pa
On 10/03/2016 03:22 AM, Peter Krempa wrote:
> On Fri, Sep 30, 2016 at 14:39:16 -0400, John Ferlan wrote:
>> v1: http://www.redhat.com/archives/libvir-list/2016-September/msg01446.html
>>
>> NOTE: Patch 1 already ACK'd
>>
>> Patches 2-4 adjusted slightly to not create/use qemuMonitorJSONQueryBlock
On Fri, Sep 30, 2016 at 14:39:16 -0400, John Ferlan wrote:
> v1: http://www.redhat.com/archives/libvir-list/2016-September/msg01446.html
>
> NOTE: Patch 1 already ACK'd
>
> Patches 2-4 adjusted slightly to not create/use qemuMonitorJSONQueryBlockArgs
> instead opting to pass all the args (also sh
v1: http://www.redhat.com/archives/libvir-list/2016-September/msg01446.html
NOTE: Patch 1 already ACK'd
Patches 2-4 adjusted slightly to not create/use qemuMonitorJSONQueryBlockArgs
instead opting to pass all the args (also shortened helper names slightly).
Patch 5 adjusted to receive all args i
