Re: [libvirt] [PATCH v2 0/5] Guest filesystem information API

2014-11-20 Thread Michal Privoznik
On 19.11.2014 23:58, John Ferlan wrote: On 11/17/2014 06:26 PM, Tomoki Sekiyama wrote: Hi, This is v2 of patchset to add virDomainGetFSInfo API. * changes in v1-v2: -[all] removed redundant NULL element at the last of returned info array -[3/5] make error messages in qemu_agent.c

Re: [libvirt] [PATCH v2 0/5] Guest filesystem information API

2014-11-20 Thread John Ferlan
On 11/20/2014 07:33 AM, Michal Privoznik wrote: On 19.11.2014 23:58, John Ferlan wrote: On 11/17/2014 06:26 PM, Tomoki Sekiyama wrote: Hi, This is v2 of patchset to add virDomainGetFSInfo API. * changes in v1-v2: -[all] removed redundant NULL element at the last of returned info

Re: [libvirt] [PATCH v2 0/5] Guest filesystem information API

2014-11-20 Thread Eric Blake
On 11/20/2014 11:11 AM, John Ferlan wrote: However, for some reason I see this build error after 2/5: make[3]: Entering directory '/home/zippy/work/libvirt/libvirt.git/tools/wireshark/src' CC libvirt_la-packet-libvirt.lo In file included from libvirt/protocol.h:5:0,

Re: [libvirt] [PATCH v2 0/5] Guest filesystem information API

2014-11-20 Thread Eric Blake
On 11/19/2014 03:58 PM, John Ferlan wrote: On 11/17/2014 06:26 PM, Tomoki Sekiyama wrote: Hi, This is v2 of patchset to add virDomainGetFSInfo API. * changes in v1-v2: -[all] removed redundant NULL element at the last of returned info array -[3/5] make error messages in qemu_agent.c

Re: [libvirt] [PATCH v2 0/5] Guest filesystem information API

2014-11-20 Thread Eric Blake
On 11/20/2014 05:33 AM, Michal Privoznik wrote: I'm also hoping someone else (eblake?) can look at the remote_protocol.x changes to ensure they encompass everything they are supposed to. Also that the usage of QEMU_JOB_QUERY not _MODIFY for the GetFSInfo seems more appropriate and is in line

Re: [libvirt] [PATCH v2 0/5] Guest filesystem information API

2014-11-20 Thread Tomoki Sekiyama
On 11/20/14, 14:17 , Eric Blake ebl...@redhat.com wrote: On 11/20/2014 05:33 AM, Michal Privoznik wrote: I'm also hoping someone else (eblake?) can look at the remote_protocol.x changes to ensure they encompass everything they are supposed to. Also that the usage of QEMU_JOB_QUERY not

Re: [libvirt] [PATCH v2 0/5] Guest filesystem information API

2014-11-20 Thread Tomoki Sekiyama
On 11/19/14, 17:58 , John Ferlan jfer...@redhat.com wrote: On 11/17/2014 06:26 PM, Tomoki Sekiyama wrote: Hi, This is v2 of patchset to add virDomainGetFSInfo API. * changes in v1-v2: -[all] removed redundant NULL element at the last of returned info array -[3/5] make error messages in

Re: [libvirt] [PATCH v2 0/5] Guest filesystem information API

2014-11-20 Thread John Ferlan
On 11/20/2014 01:19 PM, Eric Blake wrote: On 11/20/2014 11:11 AM, John Ferlan wrote: However, for some reason I see this build error after 2/5: make[3]: Entering directory '/home/zippy/work/libvirt/libvirt.git/tools/wireshark/src' CC libvirt_la-packet-libvirt.lo In file

Re: [libvirt] [PATCH v2 0/5] Guest filesystem information API

2014-11-20 Thread Tomoki Sekiyama
On 11/20/14, 18:54 , John Ferlan jfer...@redhat.com wrote: On 11/20/2014 01:19 PM, Eric Blake wrote: On 11/20/2014 11:11 AM, John Ferlan wrote: However, for some reason I see this build error after 2/5: make[3]: Entering directory '/home/zippy/work/libvirt/libvirt.git/tools/wireshark/src'

Re: [libvirt] [PATCH v2 0/5] Guest filesystem information API

2014-11-19 Thread John Ferlan
On 11/17/2014 06:26 PM, Tomoki Sekiyama wrote: Hi, This is v2 of patchset to add virDomainGetFSInfo API. * changes in v1-v2: -[all] removed redundant NULL element at the last of returned info array -[3/5] make error messages in qemu_agent.c consistent with other commands -[4/5]

[libvirt] [PATCH v2 0/5] Guest filesystem information API

2014-11-17 Thread Tomoki Sekiyama
Hi, This is v2 of patchset to add virDomainGetFSInfo API. * changes in v1-v2: -[all] removed redundant NULL element at the last of returned info array -[3/5] make error messages in qemu_agent.c consistent with other commands -[4/5] added a test case for 2 items in info-devAliases -[5/5]