Re: [libvirt] [PATCH v2 0/6] rewrite virt-host-validate to be data driven, using Go & YAML

2019-10-01 Thread Martin Kletzander
On Mon, Sep 30, 2019 at 05:21:51PM +0200, Peter Krempa wrote: On Mon, Sep 30, 2019 at 15:48:29 +0100, Daniel Berrange wrote: On Mon, Sep 30, 2019 at 10:47:39AM +0200, Martin Kletzander wrote: > On Fri, Sep 27, 2019 at 01:52:19PM +0100, Daniel P. Berrangé wrote: > > This is a followup to a

Re: [libvirt] [PATCH v2 0/6] rewrite virt-host-validate to be data driven, using Go & YAML

2019-10-01 Thread Martin Kletzander
On Tue, Oct 01, 2019 at 12:53:50PM +0100, Daniel P. Berrangé wrote: On Tue, Oct 01, 2019 at 01:36:07PM +0200, Bjoern Walk wrote: Daniel P. Berrangé [2019-09-30, 03:48PM +0100]: > In this case, our existing C language for writing our production code is > not well suited for the task we're

Re: [libvirt] [PATCH v2 0/6] rewrite virt-host-validate to be data driven, using Go & YAML

2019-10-01 Thread Daniel P . Berrangé
On Tue, Oct 01, 2019 at 01:36:07PM +0200, Bjoern Walk wrote: > Daniel P. Berrangé [2019-09-30, 03:48PM +0100]: > > In this case, our existing C language for writing our production code is > > not well suited for the task we're applying it too. You could make an > > argument that the

Re: [libvirt] [PATCH v2 0/6] rewrite virt-host-validate to be data driven, using Go & YAML

2019-10-01 Thread Bjoern Walk
Martin Kletzander [2019-09-30, 10:47AM +0200]: > On Fri, Sep 27, 2019 at 01:52:19PM +0100, Daniel P. Berrangé wrote: > > 32 files changed, 2609 insertions(+), 1045 deletions(-) > > So this ^^ plus: > > 2 languages added, 0 languages removed > > makes me feel like this goes against what you

Re: [libvirt] [PATCH v2 0/6] rewrite virt-host-validate to be data driven, using Go & YAML

2019-10-01 Thread Bjoern Walk
Daniel P. Berrangé [2019-09-30, 03:48PM +0100]: > In this case, our existing C language for writing our production code is > not well suited for the task we're applying it too. You could make an > argument that the virt-host-validate could be written in Python, but > I think it is preferred to

Re: [libvirt] [PATCH v2 0/6] rewrite virt-host-validate to be data driven, using Go & YAML

2019-09-30 Thread Peter Krempa
On Mon, Sep 30, 2019 at 15:48:29 +0100, Daniel Berrange wrote: > On Mon, Sep 30, 2019 at 10:47:39AM +0200, Martin Kletzander wrote: > > On Fri, Sep 27, 2019 at 01:52:19PM +0100, Daniel P. Berrangé wrote: > > > This is a followup to a previous PoC patch I submitted a > > > month ago: [...] > >

Re: [libvirt] [PATCH v2 0/6] rewrite virt-host-validate to be data driven, using Go & YAML

2019-09-30 Thread Daniel P . Berrangé
On Mon, Sep 30, 2019 at 10:47:39AM +0200, Martin Kletzander wrote: > On Fri, Sep 27, 2019 at 01:52:19PM +0100, Daniel P. Berrangé wrote: > > This is a followup to a previous PoC patch I submitted a > > month ago: > > > > https://www.redhat.com/archives/libvir-list/2019-September/msg00036.html >

Re: [libvirt] [PATCH v2 0/6] rewrite virt-host-validate to be data driven, using Go & YAML

2019-09-30 Thread Daniel P . Berrangé
On Mon, Sep 30, 2019 at 12:03:22PM +0200, Andrea Bolognani wrote: > On Fri, 2019-09-27 at 13:52 +0100, Daniel P. Berrangé wrote: > > The really big difference though is that I replaced the use > > of XML data files with YAML data files. This was done with > > the aim of making the data more human

Re: [libvirt] [PATCH v2 0/6] rewrite virt-host-validate to be data driven, using Go & YAML

2019-09-30 Thread Andrea Bolognani
On Fri, 2019-09-27 at 13:52 +0100, Daniel P. Berrangé wrote: > The really big difference though is that I replaced the use > of XML data files with YAML data files. This was done with > the aim of making the data more human friendly. XML is really > optimized for machines, not humans, so writing

Re: [libvirt] [PATCH v2 0/6] rewrite virt-host-validate to be data driven, using Go & YAML

2019-09-30 Thread Martin Kletzander
On Fri, Sep 27, 2019 at 01:52:19PM +0100, Daniel P. Berrangé wrote: This is a followup to a previous PoC patch I submitted a month ago: https://www.redhat.com/archives/libvir-list/2019-September/msg00036.html The commit messages in the individual patches given quite a bit of detail, so I'll

[libvirt] [PATCH v2 0/6] rewrite virt-host-validate to be data driven, using Go & YAML

2019-09-27 Thread Daniel P . Berrangé
This is a followup to a previous PoC patch I submitted a month ago: https://www.redhat.com/archives/libvir-list/2019-September/msg00036.html The commit messages in the individual patches given quite a bit of detail, so I'll keep this cover letter brief. In my previous posting I was unhappy