Re: [libvirt] [PATCH v2 01/11] domain: Document VIR_DOMAIN_XML_MIGRATABLE

2019-02-27 Thread John Ferlan
On 2/23/19 4:24 PM, Eric Blake wrote: > Commit 28f8dfdc (1.0.0) added a flag to virDomainGetXMLDesc, but > failed to document its effects. And considering that the > MIGRATABLE flag has been the source of past bugs (CVE-2014-7823, > fixed in commit b1674ad5 (1.2.11), or even cf2d4c60 (1.2.13) w

[libvirt] [PATCH v2 01/11] domain: Document VIR_DOMAIN_XML_MIGRATABLE

2019-02-23 Thread Eric Blake
Commit 28f8dfdc (1.0.0) added a flag to virDomainGetXMLDesc, but failed to document its effects. And considering that the MIGRATABLE flag has been the source of past bugs (CVE-2014-7823, fixed in commit b1674ad5 (1.2.11), or even cf2d4c60 (1.2.13) where flag mismatch broke virsh edit), make the wo